Add new tests for Get-ChildItem (FileSystemProvider) by iSazonov · Pull Request #11602 · PowerShell/PowerShell · GitHub

PR Summary

Add new tests for better code coverage in SessionStateContainer.cs and FileSystemProvider.cs.

PR Context

I prepare a code to address issue #9119 but we have not tests to cover the code paths at all. To avoid regressions we should merge the new tests before new code will be pulled.

Some bugs (#9126 and #3304) was discovered, the new tests was marked as pending.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

James Truher (@JamesWTruher) Could you please review.

Half way through reviewing

Suggested change

      
                    $DirSep = [io.path]::DirectorySeparatorChar
          
                    $DirSep = [IO.Path]::DirectorySeparatorChar

Done.

Suggested change

      
                        $result | Where-Object Name -eq "filehidden1.doc" | Should -Not -BeNullOrEmpty
          
                        $result.Name | Should -Contain "filehidden1.doc"

Done.

Suggested change

      
                        $result | Where-Object { $_ -eq "filehidden1.doc" } | Should -Not -BeNullOrEmpty
          
                        $result.Name | Should -Contain "filehidden1.doc"

Done.

Suggested change

      
                        $result | Where-Object { $_.Name -eq "filehidden1.doc" -and $_.psobject.TypeNames[0] -eq "System.IO.FileInfo"} | Should -Not -BeNullOrEmpty
          
                        $result.Where{ $_.Name -eq "filehidden1.doc"} | Should -BeOfType [System.IO.FileInfo]

Same for below

Done.

Half way through reviewing

Sorry, last commit is large (include style changes too).

Would it be better to have the filenames in a hashtable with their attribute so that you can verify the filenames are returned later in the tests? Then you could also just loop through the hashtable to create the files instead of having separate lines.

I see your point but I don't want complicate the test code because (1) there are issues we want to fix in near future, (2) there are issues we want to fix in FileSystem provider V2 future - so simple linear tests will simplify our work in future.

Steve Lee (@SteveL-MSFT) Please continue your review.

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 16, 2020

Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Jan 16, 2020

Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Aditya Patwardhan (adityapatwardhan) January 16, 2020 14:40

Ilya (iSazonov) self-assigned this Jan 16, 2020

PoshChan-Bot (PoshChan) reviewed Jan 16, 2020

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystemProviderExtended.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) requested a review from James Truher (JamesWTruher) January 16, 2020 19:15

Ilya (iSazonov) added 4 commits January 22, 2020 10:24

Add new tests for Get-ChildItem (FileSystemProvider)

87e8739

Use OS specific path separator

0fc8473

Add tests for Get-ChildItem -Name and symbolic links

82687d6

Add tests for Get-ChildItem -Depth

9a1972f

Ilya (iSazonov) force-pushed the tests-filesystemprovider-dir branch from 80f49a7 to 9a1972f Compare January 22, 2020 05:25

PoshChan-Bot (PoshChan) reviewed Jan 22, 2020

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1

Steve Lee (SteveL-MSFT) requested changes Jan 28, 2020

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 28, 2020

Address feedback

e52488a

Steve Lee (SteveL-MSFT) reviewed Jan 29, 2020

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystemProviderExtended.Tests.ps1

Steve Lee (SteveL-MSFT) reviewed Jan 29, 2020

View reviewed changes

Ilya (iSazonov) mentioned this pull request Jan 30, 2020

Adding -Name to Get-ChildItem -Recurse quietly ignores directories it isn't permitted to list #9122

Closed

Steve Lee (SteveL-MSFT) approved these changes Feb 11, 2020

View reviewed changes

Ilya (iSazonov) merged commit 9770477 into PowerShell:master Feb 12, 2020

Ilya (iSazonov) deleted the tests-filesystemprovider-dir branch February 12, 2020 03:17

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Add new tests for Get-ChildItem (FileSystemProvider) (PowerShell#11602 )

15eff2f

+                      It "Get-ChildItem -Path -Force" {
+                          $result = Get-ChildItem -Path $rootDir -Force
+                          $result.Count | Should -Be 5
+                          $result | Where-Object Name -eq "filehidden1.doc" | Should -Not -BeNullOrEmpty

+                          $result = Get-ChildItem -Path $rootDir -Name -Force
+                          $result.Count | Should -Be 5
+                          $result | Should -BeOfType [string]
+                          $result | Where-Object { $_ -eq "filehidden1.doc" } | Should -Not -BeNullOrEmpty

+                      It "Get-ChildItem -Path -Recurse -Hidden" {
+                          $result = Get-ChildItem -Path $rootDir -Recurse -Hidden
+                          $result.Count | Should -Be 4
+                          $result | Where-Object { $_.Name -eq "filehidden1.doc" -and $_.psobject.TypeNames[0] -eq "System.IO.FileInfo"} | Should -Not -BeNullOrEmpty

+                  BeforeAll {
+                      $restoreLocation = Get-Location
+                      $DirSep = [io.path]::DirectorySeparatorChar

	$DirSep = [io.path]::DirectorySeparatorChar
	$DirSep = [IO.Path]::DirectorySeparatorChar

	$result \| Where-Object Name -eq "filehidden1.doc" \| Should -Not -BeNullOrEmpty
	$result.Name \| Should -Contain "filehidden1.doc"

	$result \| Where-Object { $_ -eq "filehidden1.doc" } \| Should -Not -BeNullOrEmpty
	$result.Name \| Should -Contain "filehidden1.doc"

	$result \| Where-Object { $_.Name -eq "filehidden1.doc" -and $_.psobject.TypeNames[0] -eq "System.IO.FileInfo"} \| Should -Not -BeNullOrEmpty
	$result.Where{ $_.Name -eq "filehidden1.doc"} \| Should -BeOfType [System.IO.FileInfo]


		Set-Location $rootDir

		New-Item -Path "file1.txt" -ItemType File > $null

Add new tests for Get-ChildItem (FileSystemProvider) by iSazonov · Pull Request #11602 · PowerShell/PowerShell · GitHub

Uh oh!

Add new tests for Get-ChildItem (FileSystemProvider) - #11602

Add new tests for Get-ChildItem (FileSystemProvider)#11602Ilya (iSazonov) merged 5 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom iSazonov:tests-filesystemprovider-diriSazonov/PowerShell:tests-filesystemprovider-dirCopy head branch name to clipboard

Conversation

Ilya (iSazonov) commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 23, 2020

Uh oh!

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Jan 29, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Feb 4, 2020

Uh oh!

Ilya (iSazonov) commented Feb 10, 2020

Uh oh!

Deleted user (ghost) commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add new tests for Get-ChildItem (FileSystemProvider)#11602
Ilya (iSazonov) merged 5 commits into
PowerShell:masterfrom
iSazonov:tests-filesystemprovider-dir

Ilya (iSazonov) commented Jan 16, 2020 •
edited
Loading

Ilya (iSazonov) Jan 30, 2020 •
edited
Loading