FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vscode: Enable EditorConfig support in OmniSharp by xtqqczze · Pull Request #11627 · PowerShell/PowerShell · GitHub

vscode: Enable EditorConfig support in OmniSharp - #11627

Merged
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
xtqqczze:omnisharp-EditorConfig-support
Jan 24, 2020
Merged

vscode: Enable EditorConfig support in OmniSharp#11627
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
xtqqczze:omnisharp-EditorConfig-support

Conversation

Copy link
Copy Markdown
Contributor

PR Summary

Enable support for EditorConfig in OmniSharp.

PR Context

OmniSharp has this support since omnisharp-roslyn v1.33.0:

PR Checklist

Enable support for EditorConfig in OmniSharp. Since omnisharp-roslyn version 1.33.0, OmniSharp has had this support.

* https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md#1330---2019-07-01
* PowerShell#7357
* OmniSharp/omnisharp-roslyn#1526

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I tried enableRoslynAnalyzers. It takes many time for analyzing and we need to adjust before enable.

Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 19, 2020
Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Jan 19, 2020

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) I've used the enableRoslynAnalyzers setting as a good tool to work with when doing a cleanup / refactor of an individual file. It will probably be quite a while before we get all those analyzer recommendations into the codebase, but the majority of them do look like great suggestions to take on board.

Copy link
Copy Markdown
Collaborator

My concern is that it takes a lot of computer resources. Perhaps we could enable subset of the analyzer to highlight our code conventions.

Copy link
Copy Markdown
Contributor Author

Rain Sallow (/u/ta11ow) (@vexx32) I too am using enableRoslynAnalyzers, with additional PackageReference Roslynator.Analyzers added to a csproj of interest. I have submitted PR #11640 based on one of the analyzer recommendations, but it seems like a huge amount of work to fix all issues.

Ilya (@iSazonov) Currently Omnisharp queues all documents in the solution for code analysis, rather than running on demand, so this uses a lot of resources when developing in vscode.

Copy link
Copy Markdown
Collaborator

xtqqczze Can we configure the code analysis?

Andrew (anmenaga) merged commit ba639a6 into PowerShell:master Jan 24, 2020
xtqqczze deleted the omnisharp-EditorConfig-support branch February 1, 2020 12:46

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL