| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Enable support for EditorConfig in OmniSharp. Since omnisharp-roslyn version 1.33.0, OmniSharp has had this support. * https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md#1330---2019-07-01 * PowerShell#7357 * OmniSharp/omnisharp-roslyn#1526
There was a problem hiding this comment.
LGTM.
I tried enableRoslynAnalyzers. It takes many time for analyzing and we need to adjust before enable.
Sorry, something went wrong.
|
Ilya (@iSazonov) I've used the enableRoslynAnalyzers setting as a good tool to work with when doing a cleanup / refactor of an individual file. It will probably be quite a while before we get all those analyzer recommendations into the codebase, but the majority of them do look like great suggestions to take on board. |
Sorry, something went wrong.
|
My concern is that it takes a lot of computer resources. Perhaps we could enable subset of the analyzer to highlight our code conventions. |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32) I too am using enableRoslynAnalyzers, with additional PackageReference Roslynator.Analyzers added to a csproj of interest. I have submitted PR #11640 based on one of the analyzer recommendations, but it seems like a huge amount of work to fix all issues. Ilya (@iSazonov) Currently Omnisharp queues all documents in the solution for code analysis, rather than running on demand, so this uses a lot of resources when developing in vscode. |
Sorry, something went wrong.
|
xtqqczze Can we configure the code analysis? |
Sorry, something went wrong.
|
🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Enable support for EditorConfig in OmniSharp.
PR Context
OmniSharp has this support since omnisharp-roslyn v1.33.0:
PR Checklist