FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Regression] Fix for JEA user role in virtual account by PaulHigin · Pull Request #11668 · PowerShell/PowerShell · GitHub

[Regression] Fix for JEA user role in virtual account - #11668

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-JEA-virtualaccount
Jan 24, 2020
Merged

[Regression] Fix for JEA user role in virtual account#11668
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
PaulHigin:fix-JEA-virtualaccount

Conversation

Paul Higinbotham (PaulHigin) commented Jan 23, 2020
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This is issue #11538.

JEA user role access was not being set correctly for a user in a JEA session endpoint configuration that is configured for RunAs or virtual accounts.

PR Context

The user role access was not being allowed for RunAs/virtual accounts because the endpoint configuration was setting the UseSharedProcess to True. In this case the WinRM host cannot provide a user token needed by PowerShell to assign role access.

This is a regression from PS6, due to workflow clean up effort (#9618). The Register-PSSessionConfiguration command would automatically set an endpoint configuration to UseSharedProcess to True for workflow endpoints. Code clean up typo left the code to always set UseSharedProcess to True for any endpoint configuration by default.

Simple fix is to remove the old workflow code completely so that UseShareProcess is False by default, and only enabled by user as it works in Windows PowerShell and PowerShell 6+.

PR Checklist

Copy link
Copy Markdown
Collaborator

I added reference to #9618 where we did workflow cleanup.

Copy link
Copy Markdown
Collaborator

Have we any progress with adding remoting tests?
I hope MSFT team has such tests internally at least.

Copy link
Copy Markdown
Member

This is a regression from PS6, due to workflow clean up effort (#9618).

Great finding. It's hard to track down the regression caused by subtle changes like this one.
Ilya (@iSazonov) there is on-going efforts to setup the cross-remoting test infrastructure, but even after the infrastructure is ready, there will still be some time before we have the desired coverage in remoting scenarios.

Dongbo Wang (daxian-dbw) merged commit a7a2b12 into PowerShell:master Jan 24, 2020
Paul Higinbotham (PaulHigin) deleted the fix-JEA-virtualaccount branch January 24, 2020 20:03
Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jan 25, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL