FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Symlink creation in packaging.psm1 by TravisEz13 · Pull Request #11723 · PowerShell/PowerShell · GitHub

Fix Symlink creation in packaging.psm1 - #11723

Merged
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
TravisEz13:Fix_symlink_creation
Jan 29, 2020
Merged

Fix Symlink creation in packaging.psm1#11723
Andrew (anmenaga) merged 2 commits into
PowerShell:masterfrom
TravisEz13:Fix_symlink_creation

Conversation

Travis Plunk (TravisEz13) commented Jan 29, 2020
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Refactor symlink creation into separate function
Add symlink creation to tarball creation

PR Context

PR Checklist

@@ -379,6 +379,7 @@ function Start-PSPackage {
Version = $Version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Travis Plunk (@TravisEz13), your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://github.com/PowerShell/PowerShell/releases/download/v7.0.0-rc.2/PowerShell-7.0.0-rc.2-win-x64.msi should work

Unable to read data from the transport connection: Connection reset by peer.
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 114
114:                                 $null = Invoke-WebRequest -uri $url -RetryIntervalSec 10 -MaximumRetryCount 6

Andrew (anmenaga) changed the title Fix Symlink creation Fix Symlink creation in packaging.psm1 Jan 29, 2020
Andrew (anmenaga) added WG-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jan 29, 2020
Andrew (anmenaga) merged commit 8206e96 into PowerShell:master Jan 29, 2020
Travis Plunk (TravisEz13) deleted the Fix_symlink_creation branch January 30, 2020 18:58
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log WG-Maintainers-Build specific to affecting the build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL