FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Auto-sync current directory in WinCompat remote session by anmenaga · Pull Request #11809 · PowerShell/PowerShell · GitHub

Auto-sync current directory in WinCompat remote session - #11809

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
anmenaga:wincompat-pwd
Feb 11, 2020
Merged

Auto-sync current directory in WinCompat remote session#11809
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
anmenaga:wincompat-pwd

Conversation

Copy link
Copy Markdown

PR Summary

WinCompat uses background Windows PS remote session which has its own current directory. It has to be synchronized with local PS Core current directory for cases when proxy cmdlets rely on current directory.
This PR enables auto-sync of current directory in WinCompat remote session.

This came up in #11411 .

PR Checklist

Andrew (anmenaga) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 7, 2020
Steve Lee (SteveL-MSFT) added this to the GA-consider milestone Feb 10, 2020
ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
# after WinCompat cleanup local $PWD changes should not cause errors
Remove-module $ModuleName -Force
Pop-Location
try

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually, I think all code after the first 'Push-Location' should be in the try. If any exception is thrown during the test the original location will be reverted through the finally 'Set-Location'.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated.

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Aditya Patwardhan (adityapatwardhan) merged commit d2cb3c3 into PowerShell:master Feb 11, 2020
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
# Conflicts:
#	src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL