FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Restore the PowerShellStreamType enum with an ObsoleteAttribute by rjmholt · Pull Request #11836 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Restore the PowerShellStreamType enum with an ObsoleteAttribute - #11836

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
rjmholt:restore-stream-enum
Feb 12, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Restore the PowerShellStreamType enum with an ObsoleteAttribute#11836
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
rjmholt:restore-stream-enum

Conversation

Rob Holt (rjmholt) commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #11619.

PR Context

Returns the PowerShellStreamType enum to code, since it was public, generically named and removed. Adds an ObsoleteAttribute to prevent new usage.

Rob Holt (rjmholt) added this to the 7.0-Consider milestone Feb 12, 2020

Rob Holt (rjmholt) commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator Author

CodeFactor issues are due to reusing previous documentation comments

Travis Plunk (TravisEz13) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 12, 2020
Dongbo Wang (daxian-dbw) reviewed Feb 12, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/PowerShellStreamType.cs Outdated
/// It is not used by any other PowerShell API, and is now obsolete
/// and should not be used if possible.
/// </remarks>
[Obsolete("Formerly used in PowerShell Workflow. Use an integer or System.Management.Automation.Language.RedirectionStream instead.")]

Dongbo Wang (daxian-dbw) Feb 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use an integer or System.Management.Automation.Language.RedirectionStream instead.

Travis Plunk (@TravisEz13) and I discussed on this message, and we think it's better to not give a workaround here given that those 2 enums have different members and values.

How about change the message to This enum type was used only in PowerShell Workflow and is now obsolete.
And make sure specify true for the error parameter.

Dongbo Wang (daxian-dbw) requested changes Feb 12, 2020
View reviewed changes

Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

make sure specify true for the error parameter.

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 12, 2020
ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 12, 2020
Aditya Patwardhan (adityapatwardhan) merged commit 2cfe8a4 into PowerShell:master Feb 12, 2020
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
Restore the PowerShellStreamType enum with an ObsoleteAttribute (P…
983a2ca 
…owerShell#11836)

Deleted user (ghost) commented Feb 21, 2020

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

ghost mentioned this pull request Feb 21, 2020
Closed
Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Restore the PowerShellStreamType enum with an ObsoleteAttribute (P…
08240e0 
…owerShell#11836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
Travis Plunk (TravisEz13) TravisEz13 approved these changes
Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Assignees

Aditya Patwardhan (adityapatwardhan)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

Public APIs missing in PowerShell 7.0.0-rc.2 since 6.2.3

5 participants

Back | FazBrowse Home | New Git URL