Refactor packaging pipeline by adityapatwardhan · Pull Request #11852 · PowerShell/PowerShell · GitHub

PR Summary

Refactor package build to remove the dependency on Docker for building Windows packages.

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Aditya Patwardhan (@adityapatwardhan) Thanks for the super fast turnaround!

This template is for generating packages with signed files, so maybe named it package_windows_$...?

Changes like this can have ripple effects which are hard to identify... let's file an issue and move one.

Done. #11855

Is this replaced by

task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0

from the windows hosted build.yml?

yes

It's a little confusing seeing the package_signing.yml depend on sign_windows_xx jobs, so I think it's probably better to rename the job in windows-packaging.yml.

we should file an issue that these should be in our storage

#11853

Co-Authored-By: Dongbo Wang <dongbow@microsoft.com>

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com>

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

🎉v6.2.5 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com> # Conflicts: # tools/releaseBuild/azureDevOps/releaseBuild.yml

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com>

Refactor packaging pipeline

778f434

Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) February 14, 2020 15:29

Aditya Patwardhan (adityapatwardhan) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 14, 2020 15:29

ghost assigned Ilya (iSazonov) Feb 14, 2020

Dongbo Wang (daxian-dbw) reviewed Feb 14, 2020

View reviewed changes

Travis Plunk (TravisEz13) reviewed Feb 14, 2020

View reviewed changes

Travis Plunk (TravisEz13) approved these changes Feb 14, 2020

View reviewed changes

Update tools/releaseBuild/azureDevOps/templates/windows-packaging.yml

bbf51f1

Co-Authored-By: Dongbo Wang <dongbow@microsoft.com>

Travis Plunk (TravisEz13) merged commit 1e5655b into PowerShell:master Feb 14, 2020

Aditya Patwardhan (adityapatwardhan) deleted the RefPkgBuild branch February 14, 2020 16:49

Dongbo Wang (daxian-dbw) mentioned this pull request Feb 14, 2020

Rename the jobs in 'windows-packaging.yml' #11855

Closed

Aditya Patwardhan (adityapatwardhan) added a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020

Refactor packaging pipeline (PowerShell#11852 )

fcc03c9

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com>

Aditya Patwardhan (adityapatwardhan) added this to the 7.0.0-rc.3 milestone Feb 21, 2020

Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 21, 2020

dependabot-preview Bot mentioned this pull request May 15, 2020

Bump System.Management.Automation from 6.2.3 to 6.2.5 snoopwpf/snoopwpf#178

Closed

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Refactor packaging pipeline (PowerShell#11852 )

c4c6d38

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com>

+                    - sign_windows_arm
+                    - sign_windows_arm64
+                    - sign_windows_fxdependent
+                    - sign_windows_fxdependentWinDesktop

Refactor packaging pipeline by adityapatwardhan · Pull Request #11852 · PowerShell/PowerShell · GitHub

Uh oh!

Refactor packaging pipeline - #11852

Refactor packaging pipeline#11852
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:RefPkgBuild

Aditya Patwardhan (adityapatwardhan) commented Feb 14, 2020 •
edited
Loading

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Uh oh!

Dongbo Wang (daxian-dbw) Feb 14, 2020

Uh oh!

Travis Plunk (TravisEz13) Feb 14, 2020

Uh oh!

Dongbo Wang (daxian-dbw) Feb 14, 2020

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) Feb 14, 2020

Uh oh!

Travis Plunk (TravisEz13) Feb 14, 2020

Uh oh!

Dongbo Wang (daxian-dbw) Feb 14, 2020

Uh oh!

Travis Plunk (TravisEz13) Feb 14, 2020

Uh oh!

Travis Plunk (TravisEz13) Feb 14, 2020

Uh oh!

Deleted user (ghost) commented Feb 21, 2020

Uh oh!

Deleted user (ghost) commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

+                parentJob: ''
+              jobs:
+              - job: sign_windows_${{ parameters.Architecture }}

+                  Architecture: arm64
+                  parentJob: build_windows_arm64
-              - template: templates/windows-component-governance.yml

+                    }
+                    $toolsDir = New-Item -ItemType Directory -Path '$(Build.ArtifactStagingDirectory)\tools'
+                    $wixUri = 'https://github.com/wixtoolset/wix3/releases/download/wix311rtm/wix311-binaries.zip'

Refactor packaging pipeline by adityapatwardhan · Pull Request #11852 · PowerShell/PowerShell · GitHub

Uh oh!

Refactor packaging pipeline - #11852

Refactor packaging pipeline#11852Travis Plunk (TravisEz13) merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:RefPkgBuildadityapatwardhan/PowerShell:RefPkgBuildCopy head branch name to clipboard

Conversation

Aditya Patwardhan (adityapatwardhan) commented Feb 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Dongbo Wang (daxian-dbw) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Deleted user (ghost) commented Feb 21, 2020

Uh oh!

Deleted user (ghost) commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Refactor packaging pipeline#11852
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:RefPkgBuild

Aditya Patwardhan (adityapatwardhan) commented Feb 14, 2020 •
edited
Loading