FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove old dead code from FullCLR by iSazonov · Pull Request #11886 · PowerShell/PowerShell · GitHub

Remove old dead code from FullCLR - #11886

Merged
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
iSazonov:cleanup-coreclr-old
Feb 20, 2020
Merged

Remove old dead code from FullCLR#11886
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
iSazonov:cleanup-coreclr-old

Conversation

Ilya (iSazonov) commented Feb 19, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Remove some #if !CORECLR.

  • remove old code from FullCLR time
  • uncomment logging

PR Context

PR Checklist

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 19, 2020
Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Feb 19, 2020
@@ -233,10 +233,8 @@ protected override void ProcessRecord()
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ilya (@iSazonov), your last commit had 1 failures in PowerShell-CI-macos
Test-Connection.TraceRoute.TraceRoute works

Expected exactly '10.79.9.114', but got 127.0.0.1.
at <ScriptBlock>, /Users/runner/runners/2.164.8/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257:             $result[0].TargetAddress | Should -BeExactly $realAddress

Copy link
Copy Markdown
Collaborator Author

PoshChan-Bot (@PoshChan) please retry macos

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov), successfully started retry of PowerShell-CI-macOS

Copy link
Copy Markdown
Collaborator Author

Reopen to restart CIs.

Andrew (anmenaga) merged commit 59ad531 into PowerShell:master Feb 20, 2020
Ilya (iSazonov) deleted the cleanup-coreclr-old branch February 21, 2020 02:55

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL