| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Did you check the color rendering on Linux and/or macOS and Windows Terminal?
Sorry, something went wrong.
|
I did check on console host and win terminal, but not Linux and macOS yet. Will do that and update here. |
Sorry, something went wrong.
|
I tested the changes on console host, windows terminal, Linux terminal and macOS terminal, and all look good: Windows console hostWindows terminalLinuxmacOS |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) Please update your review |
Sorry, something went wrong.
|
LGTM. Let's merge so we can start the build |
Sorry, something went wrong.
|
Since I have tested it on all platforms, I'm OK to merge this PR. |
Sorry, something went wrong.
|
I am OK to merge this PR. |
Sorry, something went wrong.
The task asked in the review is complete
|
🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Update the map between console color to VT sequences.
The ConsoleColor to VT Escape Sequences mapping in VTUtils.cs is not accurate, and thus is updated according to https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#text-formatting
PowerShell/src/System.Management.Automation/utils/VTUtils.cs
Lines 25 to 43 in 895d4b3
The update is needed as "Bright foreground color" (e.g. bright red \x1b[91m) is rendered differently from bold color (e.g. \x1b[1;31m) in some front-end client, such as the Jupyter Notebook client.

See the 3rd and 4th output below as an example:
PR Checklist