FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix ConciseView to not show the line information within the error message by SteveL-MSFT · Pull Request #11952 · PowerShell/PowerShell · GitHub

Fix ConciseView to not show the line information within the error message - #11952

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:conciseview-positionmessage
Feb 26, 2020
Merged

Fix ConciseView to not show the line information within the error message#11952
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:conciseview-positionmessage

Conversation

Steve Lee (SteveL-MSFT) commented Feb 25, 2020
edited by daxian-dbw
Loading

Copy link
Copy Markdown
Member

PR Summary

This is a regression from a prior change that replaced usage of `n with $newline but accidentally replaced a correct usage of `n as the PositionMessage member uses `n as the newline is from a resource string. Fix is to change back usage of Split() with the newline char rather than $newline which may contain CRLF. This is a regression introduced in rc.3 from rc.2

PR Context

The error message was inadvertently including the legacy line position information.

PR Checklist

ghost assigned Ilya (iSazonov) Feb 25, 2020
Steve Lee (SteveL-MSFT) added this to the GA-consider milestone Feb 25, 2020
Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 25, 2020
Ilya (iSazonov) merged commit 2db8516 into PowerShell:master Feb 26, 2020

Copy link
Copy Markdown

🎉v7.0.0 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL