FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable `Ctrl+C` to work for global tool by adityapatwardhan · Pull Request #11959 · PowerShell/PowerShell · GitHub

Enable Ctrl+C to work for global tool - #11959

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixGblTool
Feb 26, 2020
Merged

Enable Ctrl+C to work for global tool#11959
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixGblTool

Conversation

Aditya Patwardhan (adityapatwardhan) commented Feb 26, 2020
edited
Loading

Copy link
Copy Markdown
Member

Fixes #11314

PR Summary

Global tool shim layer should not handle Ctlr+C as it does compete with the launched global tool and makes the usage of console impossible.

PR Context

PR Checklist

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) A question: pwsh can still receive Ctrl+C after adding this handler in the shim layer, right?

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) Yes, pwsh still receives the ctlr+c

Aditya Patwardhan (adityapatwardhan) changed the title Disable handling Ctlr C in the global tool shim Enable Ctrl+C to work for global tool Feb 26, 2020
Travis Plunk (TravisEz13) merged commit 4e89698 into PowerShell:master Feb 26, 2020

Copy link
Copy Markdown

Thanks!

Aditya Patwardhan (adityapatwardhan) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 3, 2020

Copy link
Copy Markdown

🎉v7.0.0 has been released which incorporates this pull request.:tada:

Handy links:

Copy link
Copy Markdown

Dropping this here to let people know this might've also fixed microsoft/vscode#86459 & microsoft/terminal#1894

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pwsh as a dotnet global tool exhibits very unusual behavior with Ctrl-C

5 participants


Back | FazBrowse Home | New Git URL