FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Publish PowerShell `vPack` for stable and better builds by TravisEz13 · Pull Request #11960 · PowerShell/PowerShell · GitHub

Publish PowerShell vPack for stable and better builds - #11960

Merged
Travis Plunk (TravisEz13) merged 6 commits into
PowerShell:masterfrom
TravisEz13:publish_vpack
Feb 27, 2020
Merged

Publish PowerShell vPack for stable and better builds#11960
Travis Plunk (TravisEz13) merged 6 commits into
PowerShell:masterfrom
TravisEz13:publish_vpack

Conversation

Travis Plunk (TravisEz13) commented Feb 26, 2020
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Publish PowerShell vPack for stable and better builds

PR Context

This is related to windows engineering

PR Checklist

ghost assigned Ilya (iSazonov) Feb 26, 2020

Copy link
Copy Markdown
Member Author

Code is ready for review now.

value: 1
- name: POWERSHELL_TELEMETRY_OPTOUT
value: 1
- group: Azure Blob variable group

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Aditya Patwardhan (@adityapatwardhan) Note that this YAML tells what variable groups it needs

displayName: 'Validate Zip and MSI Package Names'

- pwsh: |
$message = @()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

seems $message is not used

displayName: Set Build Name for Non-PR
condition: ne(variables['Build.Reason'], 'PullRequest')

- template: ./templates/vpackReleaseJob.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we consider:

  1. Adding approvals?
  2. Execute only on build.reason manual?

Travis Plunk (TravisEz13) Feb 26, 2020
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I did number 2

Let's leave 1 for when we integrate this into a deployment yaml.

Travis Plunk (TravisEz13) changed the title Publish PowerShell vPack for stable and better builds Publish PowerShell vPack for stable and better builds Feb 27, 2020
Travis Plunk (TravisEz13) merged commit c97f2d7 into PowerShell:master Feb 27, 2020
Travis Plunk (TravisEz13) deleted the publish_vpack branch February 27, 2020 18:13
Travis Plunk (TravisEz13) added this to the GA-approved milestone Feb 27, 2020
Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 27, 2020

Copy link
Copy Markdown

🎉v7.0.0 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL