FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ignore last exit code in the build step as `dotnet` may return error when SDK is not installed by adityapatwardhan · Pull Request #11972 · PowerShell/PowerShell · GitHub

Ignore last exit code in the build step as dotnet may return error when SDK is not installed - #11972

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:FixBuildLastExitcode
Feb 28, 2020
Merged

Ignore last exit code in the build step as dotnet may return error when SDK is not installed#11972
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:FixBuildLastExitcode

Conversation

Aditya Patwardhan (adityapatwardhan) commented Feb 28, 2020
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

When dotnet version installed does not match the version in global.json, dotnet may set a error exit code. Az DevOps has started failing when that happens. The PR addresses that by ignoring the last exit code.

PR Context

PR Checklist

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

NIT: since we have this in 3 places, should consider have it as a helper function, but not necessary for this PR

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 1 hour

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), this is the reminder you requested 1 hour ago

Dongbo Wang (daxian-dbw) merged commit 91c9be9 into PowerShell:master Feb 28, 2020
Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Aditya Patwardhan (adityapatwardhan) deleted the FixBuildLastExitcode branch June 8, 2020 18:24
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL