Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' by daxian-dbw · Pull Request #12203 · PowerShell/PowerShell · GitHub

PR Summary

Fix #12052

Fix a regression in PS 7.0 introduced by #11088
PowerShell should discover assemblies loaded by Assembly.Load(byte[]) and Assembly.LoadFile as in prior versions.

Assemblies loaded by Assembly.Load(byte[]) and Assembly.LoadFile are placed in special AssemblyLoadContext instances of the type System.Runtime.Loader.IndividualAssemblyLoadContext. PowerShell should return assemblies from those load context instances.

Also include a minor change to ignore the .ionide folders, which are auto-generated by VS Code C# extension to hold symbol caches.

/cc Patrick Meinecke (@SeeminglyScience)

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- Experimental feature(s) needed
  - Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

…oad(byte[])' and 'Assembly.LoadFile'

My concern is that IndividualAssemblyLoadContext is internal class and .Net is free to change the name.
Maybe more reliable to use an assembly context name ("Assembly.Load(byte[], ...)" and "Assembly.LoadFile({0})"). It is public contract and has one prefix Assembly.Load for both.

Any one can create a ALC instance with the name "Assembly.Load(byte[], ...)" or "Assembly.LoadFile(".
It's less reliable to depend on the name than the type. They can change the type name, but I think that possibility is very low, and we have test to catch the failure if the type name really changes.

🎉v7.1.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

🎉v7.0.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…oadFile' (PowerShell#12203) * Fix regression: pwsh should discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile'

Dongbo Wang (daxian-dbw) added 2 commits March 25, 2020 11:24

Fix regression: pwsh should discover assemblies loaded by 'Assembly.L…

22cc9a0

…oad(byte[])' and 'Assembly.LoadFile'

Ignore .ionide folder

d6f2a1d

ghost assigned Andrew (anmenaga) Mar 25, 2020

Dongbo Wang (daxian-dbw) requested review from Ilya (iSazonov) and Rob Holt (rjmholt) March 25, 2020 18:36

Dongbo Wang (daxian-dbw) assigned Ilya (iSazonov) and unassigned Andrew (anmenaga) Mar 25, 2020

Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Mar 25, 2020

Dongbo Wang (daxian-dbw) added this to the 7.0.x-Servicing-Consider milestone Mar 25, 2020

PoshChan-Bot (PoshChan) reviewed Mar 25, 2020

View reviewed changes

Comment thread .gitignore

Ilya (iSazonov) reviewed Mar 26, 2020

View reviewed changes

Dongbo Wang (daxian-dbw) mentioned this pull request Mar 26, 2020

Do not resolve types from assemblies that are loaded in separate AssemblyLoadContext #11088

Merged

14 tasks

Ilya (iSazonov) reviewed Mar 26, 2020

View reviewed changes

Comment thread src/System.Management.Automation/utils/ClrFacade.cs

Rob Holt (rjmholt) approved these changes Mar 27, 2020

View reviewed changes

Ilya (iSazonov) approved these changes Mar 28, 2020

View reviewed changes

Ilya (iSazonov) merged commit e741dc5 into PowerShell:master Mar 28, 2020

Ilya (iSazonov) changed the title Fix regression: pwsh should discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' Mar 28, 2020

Dongbo Wang (daxian-dbw) deleted the assembly branch March 28, 2020 18:09

Aditya Patwardhan (adityapatwardhan) modified the milestones: 7.0.x-Servicing-Consider, 7.0.1-approved Apr 20, 2020

Travis Plunk (TravisEz13) modified the milestones: 7.0.1-approved, 7.0.1 Apr 20, 2020

ghost mentioned this pull request Apr 23, 2020

Powershell 7.x : Cannot use type from dll (built for netstandard2.0) #12052

Closed

Ethan Bergstrom (ethanbergstrom) mentioned this pull request May 2, 2020

Any tips for package provider not working ethanbergstrom/Chocolatier#8

Closed

Ethan Bergstrom (ethanbergstrom) mentioned this pull request Jul 25, 2021

error trying to install package provider (for powershell core) OneGet/oneget#477

Open

Dongbo Wang (daxian-dbw) mentioned this pull request Sep 7, 2022

Do not discover assemblies loaded by Assembly.LoadFile #18047

Closed

13 tasks

Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022

Back-port to 7.0: Update list of PowerShell team members in release tools #18266

Merged

22 tasks

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' by daxian-dbw · Pull Request #12203 · PowerShell/PowerShell · GitHub

Uh oh!

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' - #12203

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile'#12203
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:assembly

Dongbo Wang (daxian-dbw) commented Mar 25, 2020 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) Mar 26, 2020

Uh oh!

Dongbo Wang (daxian-dbw) Mar 26, 2020

Uh oh!

Uh oh!

Deleted user (ghost) commented Apr 23, 2020

Uh oh!

Deleted user (ghost) commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

+                      /// </summary>
+                      private static IEnumerable<Assembly> GetPSVisibleAssemblies()
+                      {
+                          const string IndividualAssemblyLoadContext = "System.Runtime.Loader.IndividualAssemblyLoadContext";

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' by daxian-dbw · Pull Request #12203 · PowerShell/PowerShell · GitHub

Uh oh!

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile' - #12203

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile'#12203Ilya (iSazonov) merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom daxian-dbw:assemblydaxian-dbw/PowerShell:assemblyCopy head branch name to clipboard

Conversation

Dongbo Wang (daxian-dbw) commented Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Uh oh!

Ilya (iSazonov) Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Deleted user (ghost) commented Apr 23, 2020

Uh oh!

Deleted user (ghost) commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Discover assemblies loaded by 'Assembly.Load(byte[])' and 'Assembly.LoadFile'#12203
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:assembly

Dongbo Wang (daxian-dbw) commented Mar 25, 2020 •
edited
Loading