FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cleanup: Use single expectation for each It block by xtqqczze · Pull Request #12714 · PowerShell/PowerShell · GitHub

cleanup: Use single expectation for each It block - #12714

Closed
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:pester-compare-array
Closed

cleanup: Use single expectation for each It block#12714
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:pester-compare-array

Conversation

xtqqczze commented May 18, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

Convention is to assert a single expectation for each It block. [1]

PR Checklist

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I can not accept these changes and suggest to close the PR.

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 19, 2020
xtqqczze marked this pull request as ready for review May 19, 2020 09:59
xtqqczze force-pushed the pester-compare-array branch from 5f6ef00 to 8d6edcb Compare May 19, 2020 11:02
xtqqczze marked this pull request as draft May 19, 2020 11:09
xtqqczze changed the title cleanup: Use Pester4 array comparison syntax cleanup: Use single expectation for each It block May 19, 2020
ghost added the Review - Needed The PR is being reviewed label May 27, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

Copy link
Copy Markdown
Collaborator

The PR looks very dangerous. I believe this does not add benefits. I close.

xtqqczze deleted the pester-compare-array branch May 27, 2020 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL