FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add missing `.editorconfig` settings present in dotnet/runtime by xtqqczze · Pull Request #12871 · PowerShell/PowerShell · GitHub

Add missing .editorconfig settings present in dotnet/runtime - #12871

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:update-editorconfig
Jun 30, 2020
Merged

Add missing .editorconfig settings present in dotnet/runtime#12871
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
xtqqczze:update-editorconfig

Conversation

xtqqczze commented Jun 2, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Add settings from https://github.com/dotnet/runtime/blob/master/.editorconfig

We may want a different value for of the new settings, so please leave review comments,

PR Context

#7357

PR Checklist

Travis Plunk (TravisEz13) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 2, 2020
Comment thread .editorconfig Outdated
Comment thread .editorconfig Outdated
Comment thread .editorconfig Outdated
Comment thread .editorconfig Outdated
Comment thread .editorconfig Outdated

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

/azp run

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase to fix CI-static.

xtqqczze force-pushed the update-editorconfig branch from 2899921 to 0086e8c Compare June 8, 2020 09:48

Copy link
Copy Markdown
Member

ghost added the Review - Needed The PR is being reviewed label Jun 22, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

Copy link
Copy Markdown
Member

ghost removed the Review - Needed The PR is being reviewed label Jun 22, 2020
ghost added the Review - Needed The PR is being reviewed label Jun 30, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Can you please review?

Travis Plunk (TravisEz13) merged commit 940cd74 into PowerShell:master Jun 30, 2020
ghost removed the Review - Needed The PR is being reviewed label Jun 30, 2020
xtqqczze deleted the update-editorconfig branch June 30, 2020 17:45
Ilya (iSazonov) added this to the 7.1.0-preview.5 milestone Jun 30, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL