| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry, something went wrong.
|
I'm afraid I don't know much about reparse points or the Microsoft Store. Requesting review from Steve Lee (@SteveL-MSFT), Andrew (@anmenaga) and Dongbo Wang (@daxian-dbw). |
Sorry, something went wrong.
|
This feels like the right solution to me, especially because we're already treating IO_REPARSE_TAG_APPEXECLINK as though it were a link already. |
Sorry, something went wrong.
|
CI failures seem to be unrelated -- will see if there's a fix |
Sorry, something went wrong.
Co-authored-by: Robert Holt <rjmholt@gmail.com>
|
Rob Holt (@rjmholt) I rebased to pass CIs. |
Sorry, something went wrong.
|
🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Fix #9970
Add resolving a Store application path (that is a reparse point) to a real path.
SHGetFileInfo() does not understand reparse points and returns 0 ("non exe or error") so we are trying to get a real path before.
Exclude Windows code from compilation on Unix.
Exclude second extra check if an app is Windows application or console application
Add new properties (IsWindowsApplication/IsConsoleApplication) to NativeCommandProcessor to cache the check.
Before the PR we did the check twice - (1) in redirection check, (2) in background check.
I tested this manually with C:\Users\<username>\AppData\Local\Microsoft\WindowsApps\Skype.exe.
/cc Dustin L. Howett (@DHowett)
PR Context
PR Checklist