FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typo in MapSecurityZone by iSazonov · Pull Request #13921 · PowerShell/PowerShell · GitHub

Fix typo in MapSecurityZone - #13921

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
iSazonov:fix-typo-mapsecurityzone
Nov 3, 2020
Merged

Fix typo in MapSecurityZone#13921
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
iSazonov:fix-typo-mapsecurityzone

Conversation

Ilya (iSazonov) commented Oct 29, 2020
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fix typo which comes from #11884 - "Internet" and "Intranet" names are too similar.
Discovered by Michael Klement (@mklement0) #13869 (comment)

PR Context

PR Checklist

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
Ilya (iSazonov) self-assigned this Oct 29, 2020

Copy link
Copy Markdown
Collaborator Author

I could add xUnit tests for the code (in follow PR).

Copy link
Copy Markdown
Contributor

I think test are definitely called for, given the potentially grave consequences of such a logic error.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - Logic fix

Dongbo Wang (daxian-dbw) added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Nov 3, 2020
Dongbo Wang (daxian-dbw) merged commit 53e8199 into PowerShell:master Nov 3, 2020
Ilya (iSazonov) deleted the fix-typo-mapsecurityzone branch November 3, 2020 03:43
Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 3, 2020
Dongbo Wang (daxian-dbw) pushed a commit to daxian-dbw/PowerShell that referenced this pull request Nov 10, 2020

Copy link
Copy Markdown

🎉v7.1.0 has been released which incorporates this pull request.:tada:

Handy links:

prem874 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is fine

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.1.x-Done Backport to 7.1.x completed CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL