FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove `-Daily` from `install-powershell.ps1` since it no longer exists by andyleejordan · Pull Request #25124 · PowerShell/PowerShell · GitHub

Remove -Daily from install-powershell.ps1 since it no longer exists - #25124

Merged
Andy Jordan (andyleejordan) merged 2 commits into
masterfrom
install-powershell
Jun 16, 2026
Merged

Remove -Daily from install-powershell.ps1 since it no longer exists#25124
Andy Jordan (andyleejordan) merged 2 commits into
masterfrom
install-powershell

Conversation

Copy link
Copy Markdown
Member

PR Summary

This removes the -Daily flag from the install-powershell.ps1 script as daily builds have not been posted in a year, and Aditya Patwardhan (@adityapatwardhan) says there are no current plans to resume doing so.

Also updates the script to install the Preview to ~/.powershell-preview like the daily was.

PR Context

I use this for testing PowerShell Editor Services and PSScriptAnalyzer in CI against upcoming builds of PowerShell to find bugs before they make it to release.

PR Checklist

Copy link
Copy Markdown
Member Author

Required for PowerShell/PowerShellEditorServices#2225.

Andy Jordan (andyleejordan) force-pushed the install-powershell branch 3 times, most recently from d214f23 to 31bb622 Compare March 5, 2025 01:17

Copy link
Copy Markdown
Member Author

The bullet style was changed in order to satisfy the Markdown linter 🙃

Copy link
Copy Markdown
Member Author

Also required for PowerShell/PSScriptAnalyzer#2070.

Copy link
Copy Markdown
Collaborator

This removes the -Daily flag from the install-powershell.ps1 script as daily builds have not been posted in a year, and Aditya Patwardhan (@adityapatwardhan) says there are no current plans to resume doing so.

We have a request to have daily build #24566

In my understanding, daily builds are the only way for partner teams to continuously test their products.
This means that we will learn about regression only after the next preview release and only if they use it for tests.
Obviously, it's better for them to test on a daily basis than to patch up problems a year later in an emergency but we even deprived them of the opportunity.

Justin Grote (JustinGrote) commented Mar 6, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

Andy Jordan (@andyleejordan) should add a parameter alias to "Daily" to not break existing scripts. I'd say this merge as-is after that, but then a follow-on should replace daily with "CIBuild" or "GHBuild" to fetch the latest commit azdo build.

Ilya (@iSazonov) per my comments on that, a "latest main commit build" is a better approach than a daily since tests are enforced for main commits.

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) per my comments on that, a "latest main commit build" is a better approach than a daily since tests are enforced for main commits.

It depends on the needs of that project. If they want, they can track each pwsh PR and upload artifacts from it.
I would speculate that for most projects this is too expensive and doesn't make sense. Most likely, they run a full set of functional tests once a day or less.

Justin Grote (JustinGrote) commented Mar 7, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

Ilya (@iSazonov) per my comments on that, a "latest main commit build" is a better approach than a daily since tests are enforced for main commits.

It depends on the needs of that project. If they want, they can track each pwsh PR and upload artifacts from it. I would speculate that for most projects this is too expensive and doesn't make sense. Most likely, they run a full set of functional tests once a day or less.

Then they can still do that, and they'll get whatever the latest PR branch is available when they schedule their job to run on a daily basis. Solves both problems :)

Dailies are an outdated development concept from the days where most work happened "during the day" and commit checks were rare. Since PowerShell has extensive gatekeeping on the main branch, pretty much every main commit can probably be considered to be fairly stable and unbroken at least for the vast majority of test cases, so it makes sense to provide an easy way to consume these artifacts that are already being built.

Copy link
Copy Markdown
Member Author

Andy Jordan (@andyleejordan) should add a parameter alias to "Daily" to not break existing scripts. I'd say this merge as-is after that, but then a follow-on should replace daily with "CIBuild" or "GHBuild" to fetch the latest commit azdo build.

Yeah, I'm wondering if the nicer thing to do is a) warn and just install the preview instead, or b) warn and exit with error. Right now it fails and that hasn't been breaking anyone so B is an option, but A is an option, though it's kind of a lie.

Copy link
Copy Markdown
Member Author

Yeah, I'm wondering if the nicer thing to do is a) warn and just install the preview instead, or b) warn and exit with error. Right now it fails and that hasn't been breaking anyone so B is an option, but A is an option, though it's kind of a lie.

Travis Plunk (@TravisEz13) what would you prefer here and what do we want to communicate about the future of the daily build here?

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) waiting on a decision from you / maintainers ☺️

microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Mar 26, 2025

Copy link
Copy Markdown
Member Author

Also noting that we'll want to cleanup:

Also install the Preview to `~/.powershell-preview` like the daily was.

Copy link
Copy Markdown
Member Author

I never got an answer so I'm going with option A.

microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Apr 4, 2025

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) can you review this please?

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Justin Chung (jshigetomi) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 15, 2026
Copilot AI review requested due to automatic review settings June 16, 2026 19:49
Andy Jordan (andyleejordan) merged commit dc4e8fe into master Jun 16, 2026
38 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

⚠️ Not ready to approve

The current parameter attribute changes allow unsupported flag combinations (eg -UseMSI -AddToPath) and the script help no longer documents the deprecated -Daily parameter.

Pull request overview

This PR updates tools/install-powershell.ps1 to retire the “daily build” install path/metadata flow, shifting to installing the latest Preview build (and updating documentation/examples accordingly).

Changes:

  • Replaces the daily-build install path with Preview build selection based on tools/metadata.json.
  • Adds a backward-compatibility -Daily switch that maps to -Preview (with a warning).
  • Updates the companion README examples to use -Preview instead of -Daily.
File summaries
File Description
tools/install-powershell.ps1 Switches “daily” behavior to Preview selection and updates default install destination suffix to -preview.
tools/install-powershell.ps1-README.md Removes daily references and updates usage examples to -Preview.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

Comment on lines +31 to +35
[Parameter()]
[switch] $Daily, # Exists for backward compatibility

[Parameter(ParameterSetName = "Daily")]
[switch] $Daily,
[Parameter()]
[string] $Destination,
Comment on lines 9 to +12
.Parameter Destination
The destination path to install PowerShell to.
.Parameter Daily
Install PowerShell from the daily build.
Note that the 'PackageManagement' module is required to install a daily package.
.Parameter Preview
Install the latest PowerShell preview build.
- Can be called directly from Git
- Optionally allows install of the latest Preview build
- Optionally installs using the latest MSI
- Automatically looks up latest version via Git tags
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Justin Chung (jshigetomi) deleted the install-powershell branch August 17, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL