| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Required for PowerShell/PowerShellEditorServices#2225. |
Sorry, something went wrong.
|
The bullet style was changed in order to satisfy the Markdown linter 🙃 |
Sorry, something went wrong.
|
Also required for PowerShell/PSScriptAnalyzer#2070. |
Sorry, something went wrong.
We have a request to have daily build #24566 In my understanding, daily builds are the only way for partner teams to continuously test their products. |
Sorry, something went wrong.
|
Andy Jordan (@andyleejordan) should add a parameter alias to "Daily" to not break existing scripts. I'd say this merge as-is after that, but then a follow-on should replace daily with "CIBuild" or "GHBuild" to fetch the latest commit azdo build. Ilya (@iSazonov) per my comments on that, a "latest main commit build" is a better approach than a daily since tests are enforced for main commits. |
Sorry, something went wrong.
It depends on the needs of that project. If they want, they can track each pwsh PR and upload artifacts from it. |
Sorry, something went wrong.
Then they can still do that, and they'll get whatever the latest PR branch is available when they schedule their job to run on a daily basis. Solves both problems :) Dailies are an outdated development concept from the days where most work happened "during the day" and commit checks were rare. Since PowerShell has extensive gatekeeping on the main branch, pretty much every main commit can probably be considered to be fairly stable and unbroken at least for the vast majority of test cases, so it makes sense to provide an easy way to consume these artifacts that are already being built. |
Sorry, something went wrong.
Yeah, I'm wondering if the nicer thing to do is a) warn and just install the preview instead, or b) warn and exit with error. Right now it fails and that hasn't been breaking anyone so B is an option, but A is an option, though it's kind of a lie. |
Sorry, something went wrong.
Travis Plunk (@TravisEz13) what would you prefer here and what do we want to communicate about the future of the daily build here? |
Sorry, something went wrong.
|
Travis Plunk (@TravisEz13) waiting on a decision from you / maintainers ☺️ |
Sorry, something went wrong.
|
Also noting that we'll want to cleanup: |
Sorry, something went wrong.
Also install the Preview to `~/.powershell-preview` like the daily was.
|
I never got an answer so I'm going with option A. |
Sorry, something went wrong.
|
Aditya Patwardhan (@adityapatwardhan) can you review this please? |
Sorry, something went wrong.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry, something went wrong.
There was a problem hiding this comment.
The current parameter attribute changes allow unsupported flag combinations (eg -UseMSI -AddToPath) and the script help no longer documents the deprecated -Daily parameter.
Pull request overviewThis PR updates tools/install-powershell.ps1 to retire the “daily build” install path/metadata flow, shifting to installing the latest Preview build (and updating documentation/examples accordingly).
Changes:
| File | Description |
|---|---|
| tools/install-powershell.ps1 | Switches “daily” behavior to Preview selection and updates default install destination suffix to -preview. |
| tools/install-powershell.ps1-README.md | Removes daily references and updates usage examples to -Preview. |
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
Sorry, something went wrong.
| [Parameter()] | ||
| [switch] $Daily, # Exists for backward compatibility | ||
|
|
||
| [Parameter(ParameterSetName = "Daily")] | ||
| [switch] $Daily, | ||
| [Parameter()] | ||
| [string] $Destination, |
| .Parameter Destination | ||
| The destination path to install PowerShell to. | ||
| .Parameter Daily | ||
| Install PowerShell from the daily build. | ||
| Note that the 'PackageManagement' module is required to install a daily package. | ||
| .Parameter Preview | ||
| Install the latest PowerShell preview build. |
| - Can be called directly from Git | ||
| - Optionally allows install of the latest Preview build | ||
| - Optionally installs using the latest MSI | ||
| - Automatically looks up latest version via Git tags |
| Back | FazBrowse Home | New Git URL |
PR Summary
This removes the -Daily flag from the install-powershell.ps1 script as daily builds have not been posted in a year, and Aditya Patwardhan (@adityapatwardhan) says there are no current plans to resume doing so.
Also updates the script to install the Preview to ~/.powershell-preview like the daily was.
PR Context
I use this for testing PowerShell Editor Services and PSScriptAnalyzer in CI against upcoming builds of PowerShell to find bugs before they make it to release.
PR Checklist
- [ ] Issue filed:
(which runs in a different PS Host).