FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Propertyless Object not displaying after ETS introspection - Simple Fix by GregoireLD · Pull Request #26520 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fix Propertyless Object not displaying after ETS introspection - Simple Fix - #26520

Open
GregoireLD wants to merge 2 commits into
PowerShell:masterfrom
GregoireLD:ShortFix
ConversationCommits (2)ChecksFiles changed
Open

Fix Propertyless Object not displaying after ETS introspection - Simple Fix#26520
GregoireLD wants to merge 2 commits into
PowerShell:masterfrom
GregoireLD:ShortFix

Conversation

GregoireLD commented Nov 24, 2025 •
edited by iSazonov
Loading

Copy link
Copy Markdown

PR Summary

Fix #25832
This fix the case where a Propertyless object is rendered undisplayable after being inspected using Get-Member or any similar introspection commands.

PR Context

Propertyless object are usually displayed using a fallback to their ToString() methods.
But the method currently used to evaluate the "Propertyless-ness" of an object relies on a flawed evaluation:
After inspecting the object, one new property gets dynamically attached to the object, rendering it undisplayable, because no longer regarded as Propertyless.

This PR fixes and extend the current IsNotRemotingProperty function in two ways: adds the currently missing RemotingConstants.EventObject kind (currently missing from the evaluation), and also adds the PSObject.PSTypeNames kind to the exclusion list to ensure introspected propertyless objects don't get misjudged as "property-full".

Also, maybe changing the IsNotRemotingProperty into a new name like IsNotBlacklistedProperty or IsNotSkippedProperty could be a good idea to mach this function extended purpose, but I wanted to get some feedback before any name change.

The full rational and discussion prior to making this PR can be found in my issue report :
#25832

PR Checklist

GregoireLD mentioned this pull request Nov 24, 2025
Open
12 tasks
Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 24, 2025
Ilya (iSazonov) reviewed Nov 24, 2025
View reviewed changes
Comment thread src/System.Management.Automation/FormatAndOutput/common/FormatViewManager.cs
/// </summary>
internal static class OutOfBandFormatViewManager
{
private static bool IsNotRemotingProperty(string name)

Ilya (iSazonov) Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems we should rename the method. Maybe IsNotPSSpecificProperty

Comment thread src/System.Management.Automation/FormatAndOutput/common/FormatViewManager.cs
|| name.Equals(RemotingConstants.SourceJobInstanceId, StringComparison.OrdinalIgnoreCase);
|| name.Equals(RemotingConstants.SourceJobInstanceId, StringComparison.OrdinalIgnoreCase)
|| name.Equals(RemotingConstants.EventObject, StringComparison.OrdinalIgnoreCase)
|| name.Equals(PSObject.PSTypeNames, StringComparison.OrdinalIgnoreCase);

Ilya (iSazonov) Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd prefer to cover all code branches by tests.
I suggest using TestCases with ma,es of the properties and manually add the properties (one per test) to propertyless object.

microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Dec 1, 2025

Ilya (iSazonov) commented Dec 11, 2025

Copy link
Copy Markdown
Collaborator

GregoireLD Do you want to continue?

microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Dec 11, 2025

GregoireLD commented Dec 11, 2025

Copy link
Copy Markdown
Author

Ilya (@iSazonov) yes, sorry I got busy lately, but I still aim to fix it for good

microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Dec 18, 2025

microsoft-github-policy-service Bot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Muffy (muffy86) commented Jun 21, 2026

Copy link
Copy Markdown

This pull request appears inactive. If there are plans to continue work, please update the PR within 14 days; otherwise it may be closed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ilya (iSazonov) iSazonov left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Review - Needed The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hidden-only class loses ToString() formatting after Get-Member inspection

3 participants

Back | FazBrowse Home | New Git URL