FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding -Extension and -LeafBase switches to Split-Path by powercode · Pull Request #2721 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Adding -Extension and -LeafBase switches to Split-Path - #2721

Merged
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
powercode:split-path-switches
Mar 11, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Adding -Extension and -LeafBase switches to Split-Path#2721
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
powercode:split-path-switches

Conversation

Staffan Gustafsson (powercode) commented Nov 18, 2016

Copy link
Copy Markdown
Collaborator

Fixes #2700

Extension and LeafBase are specializations of Leaf, and uses System.IO.Path.GetExtension
and System.IO.Path.GetFilenameWithoutExtension to extract parts from the Leaf

Tests added in test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1

Microsoft Contribution License Agreements (msftclas) commented Nov 18, 2016

Copy link
Copy Markdown

Hi Staffan Gustafsson (@powercode), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

Staffan Gustafsson (powercode) changed the title Adding -Exension and -LeafBase switches to Split-Path Adding -Extension and -LeafBase switches to Split-Path Nov 18, 2016
James Truher (JamesWTruher) reviewed Nov 30, 2016
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated

James Truher (JamesWTruher) Nov 30, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should there be explicit tests for things like:
"$level2_1Full$fileExt$fileExt"
to ensure that the trimming is not over-zealous?

Staffan Gustafsson (powercode) Dec 2, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added.

Charu Bassi (charub) reviewed Mar 3, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs Outdated

Charu Bassi (charub) Mar 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What's the difference between LeafSet and LeafBaseSet?

Charu Bassi (charub) reviewed Mar 3, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs Outdated

Charu Bassi (charub) Mar 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The comment seems to be duplicated.

Charu Bassi (charub) reviewed Mar 3, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs Outdated

Charu Bassi (charub) Mar 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The default value of _parent used to be true. The default for a switch is False. Please revisit.

Staffan Gustafsson (powercode) Mar 4, 2017

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch. Fixing and rebasing.

Staffan Gustafsson added 3 commits March 3, 2017 22:34
Refactoring ParsePathCommand.cs (SplitPathCommand) for readability - …
1519629 
…No functionallity changes

Using auto properties when no when there is no logic in getter/setter
Removing unused code
Removing redundant qualifiers
Removing Redundant initializers
Add -Extension and -Leafbase switches to Split-Path cmdlet
b89558d 
Extension and LeafBase are specializations of Leaf, and uses System.IO.Path.GetExtension
and System.IO.Path.GetFilenameWithoutExtension to extract parts from the Leaf
Adding tests for Split-Path -LeafBase and Split-Path -Extension
33e266e

Dongbo Wang (daxian-dbw) commented Mar 10, 2017

Copy link
Copy Markdown
Member

Charu Bassi (@charub) your comments have been addressed, can you please take another look? If the change looks good, please approve the PR.

Dongbo Wang (daxian-dbw) merged commit 220eaa1 into PowerShell:master Mar 11, 2017
Staffan Gustafsson (powercode) deleted the split-path-switches branch April 19, 2017 17:28
Ilya (iSazonov) removed the Review - Needed The PR is being reviewed label Apr 20, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Adding -Extension and -LeafBase switches to Split-Path (PowerShell#2721)
fc7d206 
* Refactoring ParsePathCommand.cs (SplitPathCommand) for readability
   - Using auto properties when no when there is no logic in getter/setter
   - Removing unused code
   - Removing redundant qualifiers
   - Removing Redundant initializers
* Add -Extension and -Leafbase switches to Split-Path cmdlet
   - Extension and LeafBase are specializations of Leaf, and uses System.IO.Path.GetExtension and System.IO.Path.GetFilenameWithoutExtension to extract parts from the Leaf
* Adding tests for Split-Path -LeafBase and Split-Path -Extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
+2 more reviewers
James Truher (JamesWTruher) JamesWTruher left review comments
Charu Bassi (charub) charub left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL