Fix comments in CmdletizationCoreResources.resx - #27879
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoAug 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates resource entries in CmdletizationCoreResources.resx to address “dev rule” {StrContains="..."} comment directives that don’t match the corresponding resource values.
Changes:
- Removes/adjusts {StrContains="..."} directives from select <comment> nodes to avoid locking on substrings not present in the <value>.
- Edits a few <value> strings to collapse double spaces after periods (user-visible message text change).
- Simplifies placeholder documentation text in the affected <comment> blocks.
src/System.Management.Automation/resources/CmdletizationCoreResources.resx:136
- This PR is described as fixing dev-rule comments, but this change also alters the user-visible resource text by collapsing the double space after the period ("once. Verify" -> "once. Verify"). If this isn't intended to change message text, keep the original spacing to minimize behavioral diffs.
<value>The {0} cmdlet defines the {1} parameter set more than once. Verify that the Cmdlet Definition XML does not have duplicate parameter set names and retry.</value>
src/System.Management.Automation/resources/CmdletizationCoreResources.resx:186
- This PR is described as fixing dev-rule comments, but this change also alters the user-visible resource text by collapsing the double space after the period ("{0}. Verify" -> "{0}. Verify"). If the intent is comment-only changes, consider keeping the original resource string unchanged.
<value>The value of the Name attribute is not a valid C# identifier: {0}. Verify the Name attribute in the Cmdlet Definition XML, and then try again.</value>
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
src/System.Management.Automation/resources/CmdletizationCoreResources.resx
Outdated
Comment thread
src/System.Management.Automation/resources/CmdletizationCoreResources.resx
Outdated
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The dev rules like {StrContains="CmdletParameterMetadata"} and {StrContains="PSName"} lock values that are missing in the resource string value. This PR fixes those dev rules.