Repository navigation
[release/v7.5.12] Add GetImportModuleCommand method and session restriction check in ShowCommand - #28073
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoSep 23, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ction in `ShowCommand` (PowerShell#25557)
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
September 23, 2026 18:55
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The remote fallback is missing a statement separator, producing invalid PowerShell syntax.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1 · 2
Separate module import from serialized PowerShell script · New
Fix duplicated word in summary text · New
Backports Show-Command module-import support and restricted-session validation to v7.5.12.
Changes:
- Adds module-import command generation.
- Rejects unsupported restricted sessions.
- Adds the localized error resource.
| File | Description |
|---|---|
| src/System.Management.Automation/resources/HelpErrors.resx | Adds the restricted-session error message. |
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs | Adds restricted-session validation. |
| src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs | Generates module-import and refresh commands. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| } | ||
| else | ||
| { | ||
| scriptBase += GetSerializedCommandScript(); |
Comment on lines
+493
to
+494
| /// Gets the command to be run to in order to import a module and refresh the command data. | ||
| /// </summary> |
| /// </summary> | ||
| /// <param name="module">Module we want to import.</param> | ||
| /// <param name="isRemoteRunspace">Boolean flag determining whether Show-Command is queried in the local or remote runspace scenario.</param> | ||
| /// <param name="isFirstChance">Boolean flag to indicate that it is the second attempt to query Show-Command data.</param> |
Dongbo Wang (daxian-dbw)
approved these changes
Sep 23, 2026
Justin Chung (jshigetomi)
approved these changes
Sep 23, 2026
Aditya Patwardhan (adityapatwardhan)
merged commit a78ac39
into
PowerShell:release/v7.5.12
Sep 23, 2026
36 checks passed
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.5.12/25557-eef085210
branch
September 23, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25557 to release/v7.5.12
Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Travis Plunk (@TravisEz13)
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Fixes #25556, where Show-Command lacks the module import helper behavior and can run in unsupported restricted remoting sessions instead of returning a clear terminating error.
Regression
REQUIRED: Check exactly one box.
The Show-Command behavior regression was introduced by #20593.
Testing
The backport cherry-picked cleanly and passes git diff --check and HelpErrors.resx XML parsing. Builds of the two affected projects were attempted after restoring dependencies but were blocked in an unrelated dependency project by missing generated DotNetEventingStrings resources in Microsoft.PowerShell.CoreCLR.Eventing.
Risk
REQUIRED: Check exactly one box.
Medium risk because this changes Show-Command behavior and module-import script generation, but the changes are limited to the graphical host helper and an explicit restricted-session guard. The backport cherry-picked cleanly.