Repository navigation
[release/v7.6.7] Prevent localization of WPF key gesture strings - #28097
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 24, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
Adds localization metadata to preserve WPF key gesture tokens and invariant API identifiers, fixing localized Out-GridView and Show-Command failures.
Changes:
- Protects eight zoom shortcut strings from translation.
- Protects Columns, Items, and View identifiers in invariant messages.
| File | Description |
|---|---|
| src/Microsoft.Management.UI.Internal/resources/public.UICultureResources.resx | Updated as part of this pull request. |
| src/Microsoft.Management.UI.Internal/resources/public.InvariantResources.resx | Updated as part of this pull request. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 24, 2026
Dongbo Wang (daxian-dbw)
merged commit 68964a3
into
PowerShell:release/v7.6.7
Sep 24, 2026
35 of 36 checks passed
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.7/28020-a049fa38e
branch
September 24, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28020 to release/v7.6.7
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Fixes #27994 where WPF key gesture tokens used by Out-GridView and Show-Command were being translated in localized resources, causing those commands to fail in non-English locales. This PR preserves the key gesture tokens and protects API identifiers embedded in invariant resource messages so they are not localized.
Regression
REQUIRED: Check exactly one box.
Regression introduced when the WPF key gesture strings were exposed for localization; they were translated in non-English locales, breaking Out-GridView and Show-Command. Reported in #27994.
Testing
Verified that Out-GridView and Show-Command key gestures function correctly under non-English locales once the key gesture tokens are preserved from localization. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7.
Risk
REQUIRED: Check exactly one box.
Low risk: marks specific resource strings as non-localizable/protected; the localized .resx files are auto-updated by the Localization Pipeline. Narrow, well-scoped fix for a reported customer bug.