| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Co-authored-by: Justin Chung <chungjustin@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
There was a problem hiding this comment.
Critical publishing and localized PDP metadata issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Backports a simplification of Microsoft Store listing metadata and publishing for release/v7.6.7.
Changes:
| File | Summary |
|---|---|
| assets/AppxManifest.xml | Adds localized Store resource declarations; localized PDPs still require AppStoreName removal. |
| .pipelines/templates/release-MSIX-Publish.yml | Adds release-note substitution; localized PDPs lack the required placeholders. |
| .pipelines/templates/package-store-package.yml | Simplifies StoreBroker packaging inputs. |
| .pipelines/store/SBConfig.json | Removes obsolete media settings. |
| .pipelines/store/PDPs/PDP/en-US/PDP.xml | Adds placeholder-based release notes. |
| .pipelines/store/PDPs/PDP-Media/en-US/.gitkeep | Removes the obsolete media-tree marker. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| foreach ($placeholder in $releaseNoteVariables.Keys) { | ||
| if (-not $releaseNotes.Contains($placeholder)) { | ||
| throw "Store release notes for '$language' do not contain the required placeholder '$placeholder'." | ||
| } |
| <Resource Language="cs"/> | ||
| <Resource Language="de"/> | ||
| <Resource Language="es"/> | ||
| <Resource Language="fr"/> | ||
| <Resource Language="it"/> |
| Back | FazBrowse Home | New Git URL |
Backport of #27968 to release/v7.6.7
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Justin Chung (@jshigetomi)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Simplifies the Microsoft Store listing pipeline by keeping localized release-note language in the PDP and removing the now-redundant PDP-Media tree and AppStoreName mutation.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Verified that the Store release pipeline correctly uses the PDP as the static source of listing language and only replaces VERSION/CHANGELOGLINK placeholders during publishing. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on the current release/v7.6.7 (after syncing to the latest upstream, which includes the revert of a previous mis-ordered backport of a dependent PR).
Risk
REQUIRED: Check exactly one box.
Low risk: Store release pipeline/packaging change only. Removes redundant PDP media tree and AppStoreName mutation, and limits release-time text replacement to version-specific placeholders. Does not affect product runtime behavior. This exact commit was previously backported to v7.6.7 (PR #28079) and later reverted for unrelated reasons; re-applying it now.