Repository navigation
[release/v7.6.10] Fix module-only vPack build feed credentials - #28362
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoNov 5, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
November 5, 2026 19:34
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Module-only vPack and MSIX restores require Azure Pipelines runtime validation because static review cannot confirm secret propagation, credential-provider authentication, or service-connection feed access.
No open issues 🎉
What changed in this PRBackports #28356 to release/v7.6.10, fixing authenticated bundled-module restores in vPack and MSIX builds when UseEarlyAccessModules is enabled without IsEarlyAccess.
Changes:
- Explicitly maps secret feed credentials into both build-step environments while preserving release-specific runtime-feed-key behavior.
- Adds regression coverage for both direct credential mappings.
- Documents the requirement to explicitly export secret variables.
| File | Description |
|---|---|
| test/infrastructure/NugetConfig.Tests.ps1 | Adds checks for direct credential mappings in both build steps. |
| docs/building/internals.md | Documents explicit secret environment mapping requirements. |
| .pipelines/templates/stages/PowerShell-vPack-Stages.yml | Maps feed credentials into the vPack build environment. |
| .pipelines/MSIXBundle-vPack-Official.yml | Maps feed credentials into the MSIX build environment. |
Review effort: Balanced
Sorry, something went wrong.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Nov 5, 2026
Dongbo Wang (daxian-dbw)
merged commit ac0b83b
into
PowerShell:release/v7.6.10
Nov 5, 2026
35 checks passed
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.10/28356-1aac7f5e3
branch
November 5, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28356 to release/v7.6.10
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Aditya Patwardhan (@adityapatwardhan)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes authenticated bundled-module restores in vPack and MSIX builds when UseEarlyAccessModules is enabled without IsEarlyAccess. Both build steps explicitly map the secret VSS_NUGET_EXTERNAL_FEED_ENDPOINTS variable into their environment, since Azure Pipelines does not automatically export secret variables.
Customer Impact
Regression
REQUIRED: Check exactly one box.
Fixes credential mapping omitted when the internal module-feed feature from #28326 was backported to release/v7.6.10 via #28355.
Testing
Includes the original PR's regression coverage requiring direct secret credential mappings in both build-step environment blocks. Independent review confirmed the intended mappings, preservation of release runtime-key behavior, documentation and regression additions, no remaining YAML conflict markers, and a passing git diff --check HEAD. Local YAML parsing was skipped at the user's request; local Pester tests were not run. Cherry-pick completed as 3a91ff5 and the worktree is clean. Backport CI, including Azure Pipelines authentication validation, must pass before merge.
Risk
REQUIRED: Check exactly one box.
Changes shared build pipeline authentication, but the fix is limited to explicit environment mappings for the existing secret variable. Release-specific runtime-key behavior is unchanged, and regression tests cover both mappings. CI validation is required before merge.
Merge Conflicts
Resolved conflicts in .pipelines/MSIXBundle-vPack-Official.yml and .pipelines/templates/stages/PowerShell-vPack-Stages.yml. In both files, added a direct VSS_NUGET_EXTERNAL_FEED_ENDPOINTS environment mapping to the Build Windows Universal step. Preserved the release vPack template's existing unconditional __DOTNET_RUNTIME_FEED_KEY mapping. The release MSIX pipeline has no IsEarlyAccess parameter or runtime-feed-key mapping, so did not import master's unrelated conditional runtime-key block. Documentation and regression tests applied without conflicts.