Repository navigation
Clear session authorization headers on redirect retries - #28398
Open
Justin Chung (jshigetomi) wants to merge 1 commit into
Open
Justin Chung (jshigetomi) wants to merge 1 commit into
Justin Chung (jshigetomi) wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Redirect handling permanently removes Authorization from a caller-supplied web session, breaking later requests that reuse it, and regression coverage for redirected retries is missing.
2 open issuesAvoid permanently removing Authorization from the caller's WebSession · New
Add retry tests for redirected requests with session Authorization headers · New
This PR hardens redirect retries in the shared web cmdlet implementation by preventing reuse of session-level authorization unless explicitly preserved.
Changes:
- Removes Authorization from both session headers and redirected requests when -PreserveAuthorizationOnRedirect is disabled.
- Runs this cleanup even when the redirected request already lacks the header.
| File | Description |
|---|---|
| src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs | Extends redirect authorization cleanup to session headers used when rebuilding requests for retries. |
Review effort: Balanced
Sorry, something went wrong.
Comment thread
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
| if (isRedirect && !PreserveAuthorizationOnRedirect && request.Headers.Contains(HttpKnownHeaderNames.Authorization)) | ||
| if (isRedirect && !PreserveAuthorizationOnRedirect) | ||
| { | ||
| WebSession?.Headers?.Remove(HttpKnownHeaderNames.Authorization); |
Comment thread
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
| if (isRedirect && !PreserveAuthorizationOnRedirect && request.Headers.Contains(HttpKnownHeaderNames.Authorization)) | ||
| if (isRedirect && !PreserveAuthorizationOnRedirect) | ||
| { | ||
| WebSession?.Headers?.Remove(HttpKnownHeaderNames.Authorization); |
Anam Navied (anamnavi)
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAt least 1 approving review is required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist