Fix casting single element array to generic collection by daxian-dbw · Pull Request #3170 · PowerShell/PowerShell · GitHub

Can we use Compare-Object and exclude Count at all?

Yes, the Count key is not necessary, and I updated the tests to avoid it.
Instead of using a loop or Compare-Object, I think $result -join ";" | Should Be ($Elements -join ";") is better here. In case the results are different, I can see the whole set of results and expected values in the log.

👍
Closed.

Perhaps it makes sense to add tests for complex type items (array, hash, psobject) because code use LanguagePrimitives.ConvertTo?

I added one more set of tests for [List[FileInfo]] cast from string or array of strings. If you think more tests is needed in this area, feel free to open an issue.

I suppose that's enough.
Closed.

Why we split testCases1 and testCases2? It seems the test code is the same.

Good point :) I thought the FileInfo test needs to be @($result.Name) -join ";", but $result -join ";" should work too.

LGTM for tests.

Dongbo Wang (@daxian-dbw) Please clarify for me: Is the PR related with return ,$arrayVar ?

Ilya (@iSazonov) this PR is not related to the return ,$array approach to prevent unraveling the output. This PR is only for fixing #2208, so that you can cast a one-element array to a generic collection.

Dongbo Wang (@daxian-dbw) Thanks for clarify!

I have one comment on the code - it would be good to ensure you know what the regression was from V4 and that we have tests for it - so we ensure this fix (which looks right to me) doesn't regress anything else.

Other than that, just the 2 minor comments on the tests.

Also test > 1 string converting to List[int]?

Sure. Fixed.

It would be less surprising to me if Command was just a script block and here you wrote:

$result = . $Command

The resulted collection will be unraveled if I use $result = . {[Collections.Generic.List[int]]@(1)}.

In order to prevent unraveling, a comma needs to be prefixed like "{,[Collections.Generic.List[int]]@(1)}".
But then the test case title becomes ",[Collections.Generic.List[int]]@(1)" which I thought was more confusing than "$result = [Collections.Generic.List[int]]@(1)" and that's why I choose the current form.
Do you want me to change back to {, [Collections.Generic.List[int]]@(1)}?

I see - neither is great - I'm fine either way then.
Because you tried what I suggested first - maybe it's worth a comment to save someone else the trouble trying to change it.

Got it. Will add a comment.

Comment added.

Fix casting single element array to generic collection

658883a

Dongbo Wang (daxian-dbw) assigned Jason Shirk (lzybkr) Feb 19, 2017

Dongbo Wang (daxian-dbw) requested a review from Jason Shirk (lzybkr) February 19, 2017 05:48

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Feb 19, 2017

Ilya (iSazonov) reviewed Feb 19, 2017

View reviewed changes

PowerShellTeam added the Review - Needed The PR is being reviewed label Feb 20, 2017

Dongbo Wang (daxian-dbw) added 2 commits February 20, 2017 15:17

Fix comments in tests

b8cf316

Fix the test a bit more

7531634

Ilya (iSazonov) reviewed Feb 21, 2017

View reviewed changes

One more fix in the test

8d0907c

Dongbo Wang (daxian-dbw) mentioned this pull request Feb 21, 2017

Define roles and their responsibilities in a PR #3168

Merged

Jason Shirk (lzybkr) reviewed Feb 22, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) added 2 commits February 22, 2017 13:28

add test for casting array with more than 1 string elements

eed79d1

Add a comment

d058513

Jason Shirk (lzybkr) approved these changes Feb 23, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) merged commit 16ff197 into PowerShell:master Feb 23, 2017

Dongbo Wang (daxian-dbw) deleted the cast branch February 23, 2017 07:10

Ilya (iSazonov) removed the Review - Needed The PR is being reviewed label Mar 27, 2017

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Fix casting single element array to generic collection (PowerShell#3170 )

46c7c84

+                          $testCases1 = @(
+                              @{ Command = {$result = [Collections.Generic.List[int]]@(1)};      CollectionType = 'List`1'; ElementType = "Int32";  Elements = @(1) }
+                              @{ Command = {$result = [Collections.Generic.List[int]]@(1,2)};    CollectionType = 'List`1'; ElementType = "Int32";  Elements = @(1,2) }
+                              @{ Command = {$result = [Collections.Generic.List[int]]"4"};       CollectionType = 'List`1'; ElementType = "Int32";  Elements = @(4) }

+                          for ($i = 0; $i -lt $Count; $i++)
+                          {
+                              $result[$i] | Should Be $Elements[$i]
+                          }

+                              @{ Command = {$result = [System.Collections.ObjectModel.Collection[int]]@(1)};   CollectionType = 'Collection`1'; ElementType = "Int32"; Count = 1; Elements = @(1) }
+                              @{ Command = {$result = [System.Collections.ObjectModel.Collection[int]]@(1,2)}; CollectionType = 'Collection`1'; ElementType = "Int32"; Count = 2; Elements = @(1,2) }
+                              @{ Command = {$result = [System.Collections.ObjectModel.Collection[int]]"4"};    CollectionType = 'Collection`1'; ElementType = "Int32"; Count = 1; Elements = @(4) }

+                          $result -join ";" | Should Be ($Elements -join ";")
+                      }
+                      It "<Command>" -TestCases $testCases2 {

+                          param($Command, $CollectionType, $ElementType, $Elements)
+                          $result = $null
+                          . $Command

Fix casting single element array to generic collection by daxian-dbw · Pull Request #3170 · PowerShell/PowerShell · GitHub

Uh oh!

Fix casting single element array to generic collection - #3170

Fix casting single element array to generic collection#3170Dongbo Wang (daxian-dbw) merged 6 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom daxian-dbw:castdaxian-dbw/PowerShell:castCopy head branch name to clipboard

Conversation

Dongbo Wang (daxian-dbw) commented Feb 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Feb 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Feb 22, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Feb 22, 2017

Uh oh!

Ilya (iSazonov) commented Feb 22, 2017

Uh oh!

Jason Shirk (lzybkr) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix casting single element array to generic collection#3170
Dongbo Wang (daxian-dbw) merged 6 commits into
PowerShell:masterfrom
daxian-dbw:cast

Dongbo Wang (daxian-dbw) Feb 20, 2017 •
edited
Loading