| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@PetSerAl, It will cover your contributions to all Microsoft-managed open source projects. |
Sorry, something went wrong.
|
Code changes look good - we do need the cla to be signed before it can be merged. |
Sorry, something went wrong.
|
PetSerAl Thanks for your contribution! |
Sorry, something went wrong.
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Sorry, something went wrong.
|
PetSerAl, |
Sorry, something went wrong.
|
One possible breaking change came to my mind: $a = ,,$false
$b = ,[PSObject](,$false)
!!$a # $true
!!$b # was $false, now is $trueSo, this PR make PowerShell behavior more consistent in regard to wrapping array into [PSObject]. But, is this change in behavior acceptable, Dongbo Wang (@daxian-dbw)? |
Sorry, something went wrong.
|
I think the behavior with the fix reflects the original intention of the code. Here is the comment in "case 1" before returning true:
And as you said, now the conversion is more consistent: $true -eq $a True $true -eq $b False After Fix $true -eq $a True $true -eq $b True Using a nested array in if condition should be rare. I think this behavior change is acceptable. Jason Shirk (@lzybkr) any thoughts? |
Sorry, something went wrong.
|
It's definitely obscure, I'm not worried about the change. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixing #3207