Fix use of registry in nightly tests causing failure on Linux - #3377
Fix use of registry in nightly tests causing failure on Linux#3377Dongbo Wang (daxian-dbw) merged 1 commit into
Conversation
Sorry, something went wrong.
|
This if((-not ($skipTest)) -and $IsWindows) block was introduced because our default-browser-discovery code, which was used in Get-Help -Online, doesn't work correctly on the Azure code-coverage VM (see PR #3051). After #3281, that code was repalced by calling into ShellExecuteEx. Although I never tried on the Azure code-coverage VM, I think the problem should be solved, and if that's the case, this if block can be removed completely. |
Sorry, something went wrong.
|
LGTM, I'm going to re-assign it to Dongbo. If he is right that we don't need this code, it would be better to remove it completely. |
Sorry, something went wrong.
|
Dongbo Wang (@daxian-dbw) since this is blocking nightly's from passing, we should make a call on this sooner than later. perhaps we should merge this to get it passing and separately see if the code is still needed for CC? |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) that sounds reasonable. #3079 is tracking this issue. |
Sorry, something went wrong.
It appears that Pester is causing PowerShell to reflect on the Win32.Registry type which causes a type initialization exception even if not being used on Linux. Changed usage of registry to psdrive to avoid this problem.
Addresses #3098