FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add tab completion for Select-Object -ExcludeProperty -ExpandProperty by iSazonov · Pull Request #3443 · PowerShell/PowerShell · GitHub

Add tab completion for Select-Object -ExcludeProperty -ExpandProperty - #3443

Merged
Jason Shirk (lzybkr) merged 2 commits into
PowerShell:masterfrom
iSazonov:is-expandproperty
Mar 29, 2017
Merged

Add tab completion for Select-Object -ExcludeProperty -ExpandProperty#3443
Jason Shirk (lzybkr) merged 2 commits into
PowerShell:masterfrom
iSazonov:is-expandproperty

Conversation

Copy link
Copy Markdown
Collaborator

Close #3416

$result.CompletionMatches[1].CompletionText | Should Be "-NoClobber"
$result.CompletionMatches[2].CompletionText | Should Be "-NoOverwrite"
}
It "Issue#3416 - 'Select-Object -ExcludeProperty <tab>' should work" {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This file is the only one where we have issues numbers in the output of the test - I'm not sure how useful that is though.

I find git blame sufficient for tracking back to an issue, but comments are also sufficient. In the output though - it's just clutter in my opinion.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I already have this issue opened to eventually address this: #3369

It "Issue#3416 - 'Select-Object -ExcludeProperty <tab>' should work" {
$cmd = "Get-Date | Select-Object -ExcludeProperty "
$result = TabExpansion2 -inputScript $cmd -cursorColumn $cmd.Length
$result.CompletionMatches.Count | Should Be 15

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This could be a fragile test, e.g. if a new version of .Net adds a property.

A more reliable test would look for specific results and not care about ordering.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Jason Shirk (lzybkr) merged commit 39be710 into PowerShell:master Mar 29, 2017
Ilya (iSazonov) deleted the is-expandproperty branch March 30, 2017 04:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL