| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Now creates a file symlink to a file target and to an non-existent target, and a directory symlink to a directory target. Also updated tests.
| $fileInfo.Attributes -band $DirLinkMask | Should Be $DirLinkMask | ||
|
|
||
| # Remove the link explicitly to avoid broken symlink issue | ||
| Remove-Item $FullyQualifiedLink -Force |
There was a problem hiding this comment.
Is it still relevant?
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, is what still relevant?
Sorry, something went wrong.
There was a problem hiding this comment.
Here Remove-Item is workaround for a bug. Is the bug already fixed?
Sorry, something went wrong.
There was a problem hiding this comment.
Ah. I didn't know what "broken symlink issue" the author was referring to, so I didn't remove another dev's code. I am working on a Remove-Item issue, but I want to get this in so I can write tests using New-Item rather than shelling out a mklink command.
Sorry, something went wrong.
There was a problem hiding this comment.
I guess it's about problem with recursion when there are symlink. It is seems already fixed. It is not related with your PR.
Closed.
Sorry, something went wrong.
|
LGTM. |
Sorry, something went wrong.
|
Joey Aiello (@joeyaiello), Steve Lee (@SteveL-MSFT) Can whoever else needs to review this please do so? I have another issue that is waiting on this one to finish updating its PR, then I'll likely want to use changes from that one in yet another issue. |
Sorry, something went wrong.
|
cc @PowerShell/area-providers |
Sorry, something went wrong.
|
jeffbi Thanks very much for great PR description! |
Sorry, something went wrong.
|
Mike Richmond (@mirichmo) Steve Lee (@SteveL-MSFT) The PR block #3441. 😕 Could you please continue with the PR? |
Sorry, something went wrong.
|
jeffbi could you please help me to understand how the change in FileSystemProvider.cs fixed the issue? |
Sorry, something went wrong.
|
jeffbi Never mind, isDirectory is the key here. The change looks good. |
Sorry, something went wrong.
|
Dongbo Wang (@daxian-dbw) Thanks for quick response! |
Sorry, something went wrong.
…hell#3509) Now `New-Item` can create a file symlink to a file target or to a non-existent target. It can also create a directory symlink to a directory target on Windows.
| Back | FazBrowse Home | New Git URL |
Fix #2915
Now creates a file symlink to a file target and to an non-existent target, and a directory symlink to a directory target.
Creating Links with New-Item
The New-Item cmdlet allows for creating file system links.
In general, New-Item can create four types of links:
The following table shows the types of links and targets the New-Item cmdlet can create on Windows:
The following table shows the types of links and targets the New-Item cmdlet can create on Linux and OS X: