Get-Help should find help files under $pshome by chunqingchen · Pull Request #3528 · PowerShell/PowerShell · GitHub

Relevant issue: #2653 #2649

Steps to reproduce

get-help about*
Expected behavior

get-help should be able to find the latest help files under $pshome

Actual behavior

get-help only get the files from C:\Windows\System32\WindowsPowerShell\v1.0

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.15016.1000
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15016.1000
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

If we use SilentlyContinue we do not need to use Test-Path.
We can move New-Item's in BeforeAll:

BeforeAll {
    $helpFile = "about_testCase.help.txt" 
    New-Item -ItemType Directory -Path "$PSHOME\en-US" -ErrorAction SilentlyContinue
    New-Item -ItemType File -Path "$PSHOME\en-US\$helpFile" -Value "about_test" -ErrorAction SilentlyContinue
}

Closed.

Please move it to AfterAll.

Closed.

You missed "}".

Please remove the extra line.

Closed.

Can we verify the exact value instead of $null?

Closed.

Should this be:

$helpContent | Should Not BeNullOrEmpty

Please clarify - is "Module" hardcoded for searching help files? And do this folder always exist? Maybe we should New-Item for it too?

I restarted MacOS because it appeared to have an issue downloading dotnet cli

Chunqing Chen (@chunqingchen) please verify this also addresses #2649

Should be as follows to avoid output on console.

$null = New-Item -ItemType Directory -Path "$PSHOME\en-US" -ErrorAction SilentlyContinue

resolved

Same as above.

resolved

Should this be:

$helpContent | Should Not BeNullOrEmpty

Aditya Patwardhan (@adityapatwardhan) your comments are resolved

Is this test case only meant to run on en-US? If it is, then you should skip it for non-English runs. Otherwise, please use (get-uiculture).Name.

resolved

This check should probably be $helpContent | Should Match "about_test"

resolved

Francisco Gamino (@Francisco-Gamino) thanks, your comments are resolved

Also, does this tests run on Linux? If it does, then please use Join-Path instead of "$path\value"
E.g.,
$helpContentPath = join-path $PSHOME $culture
if (-not (test-path $helpContentPath))
{
}

Francisco Gamino (@Francisco-Gamino) thanks, your comment is resolved !

Francisco Gamino (@Francisco-Gamino) && Aditya Patwardhan (@adityapatwardhan) Do you guys have any more concerns or is this ready for merge?

Please update this path $modulePath\en-US to $modulePath(get-uiculture).name. Other than that, it looks good. Thanks.

This path should be $modulePath(get-culture).name

Chunqing Chen (@chunqingchen) Changes approved.

Francisco Gamino (@Francisco-Gamino) en-us is replaced with culture
Mike Richmond (@mirichmo) please merge the change.

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Apr 11, 2017

Ilya (iSazonov) reviewed Apr 11, 2017

View reviewed changes

Ilya (iSazonov) reviewed Apr 12, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) requested a review from Francisco Gamino (Francisco-Gamino) April 14, 2017 21:58

Dongbo Wang (daxian-dbw) assigned Mike Richmond (mirichmo) Apr 14, 2017

Steve Lee (SteveL-MSFT) requested a review from Aditya Patwardhan (adityapatwardhan) April 18, 2017 22:59

Aditya Patwardhan (adityapatwardhan) requested changes Apr 19, 2017

View reviewed changes

Francisco Gamino (Francisco-Gamino) suggested changes Apr 20, 2017

View reviewed changes

Francisco Gamino (Francisco-Gamino) suggested changes Apr 21, 2017

View reviewed changes

Chunqing Chen (chunqingchen) added 2 commits April 24, 2017 16:13

Get-Help should find help files under pshome

4d5d223

Merge branch 'master' into bugfix3

407b2b0

Steve Lee (SteveL-MSFT) added this to the 6.0.0-beta1 milestone May 1, 2017

Francisco Gamino (Francisco-Gamino) approved these changes May 1, 2017

View reviewed changes

Aditya Patwardhan (adityapatwardhan) approved these changes May 1, 2017

View reviewed changes

Mike Richmond (mirichmo) merged commit 5a82b10 into PowerShell:master May 1, 2017

Steve Lee (SteveL-MSFT) mentioned this pull request May 2, 2017

Get-Help does not list all 'About*' topics #2653

Closed

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Get-Help should find help files under pshome (PowerShell#3528 )

8a0bb01

+              Describe "Validate about_help.txt under culture specific folder works" -Tags @('CI') {
+                  BeforeAll {
+                      $modulePath = "$pshome\Modules\Test"
+                      $null = New-Item -Path $modulePath\en-US -ItemType Directory -Force

Get-Help should find help files under $pshome by chunqingchen · Pull Request #3528 · PowerShell/PowerShell · GitHub

Uh oh!

Get-Help should find help files under $pshome - #3528

Get-Help should find help files under $pshome#3528Mike Richmond (mirichmo) merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom chunqingchen:bugfix3Copy head branch name to clipboard

Conversation

Chunqing Chen (chunqingchen) commented Apr 11, 2017 • edited by joeyaiello Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Apr 12, 2017

Uh oh!

Steve Lee (SteveL-MSFT) commented Apr 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Apr 25, 2017

Uh oh!

Mike Richmond (mirichmo) commented Apr 26, 2017

Uh oh!

Francisco Gamino (Francisco-Gamino) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented May 1, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented May 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Get-Help should find help files under $pshome#3528
Mike Richmond (mirichmo) merged 2 commits into
PowerShell:masterfrom
chunqingchen:bugfix3

Chunqing Chen (chunqingchen) commented Apr 11, 2017 •
edited by joeyaiello
Loading

Ilya (iSazonov) Apr 12, 2017 •
edited
Loading