FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixing #3624 - Readline crash with @{<tab> by powercode · Pull Request #3626 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fixing #3624 - Readline crash with @{<tab> - #3626

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
powercode:ht-3624
Apr 25, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Fixing #3624 - Readline crash with @{<tab>#3626
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
powercode:ht-3624

Conversation

Staffan Gustafsson (powercode) commented Apr 22, 2017 •
edited by iSazonov
Loading

Copy link
Copy Markdown
Collaborator

Fix #3624

Dongbo Wang (daxian-dbw) reviewed Apr 24, 2017
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Outdated
}
break;
case TokenKind.AtCurly:
// Handle scenarios such as Sort-Object @{<tab> || gci | Format-Table @{

Dongbo Wang (daxian-dbw) Apr 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sort-Object @{ || gci | Format-Table @{

minor comment: can we change this to 'Sort-Object @{<tab>' or 'gci | Format-Table @{'? I think it's more readable.

Dongbo Wang (daxian-dbw) reviewed Apr 24, 2017
View reviewed changes
Comment thread test/powershell/Host/TabCompletion/BugFix.Tests.ps1 Outdated
}
}

It "Issue#3628 - 'Sort-Object @{<tab> should work" {

Dongbo Wang (daxian-dbw) Apr 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

'Sort-Object @{ should work

Minor comment: did you miss a single quote? :)

Staffan Gustafsson (powercode) commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) Thx for the review. Issues addressed.

Ilya (iSazonov) commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

LGTM.

Staffan Gustafsson (@powercode) I added link on Issue in description. The Issue will be auto closed after merge. And it is useful to see a link to the PR in the Issue.

Staffan Gustafsson (powercode) commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator Author

Ilya (@iSazonov) I thought the number in the title did so, but apparently I was incorrect :)

Dongbo Wang (daxian-dbw) merged commit 5bdcff5 into PowerShell:master Apr 25, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Fix tab completion with '@{<tab>' to avoid crash in PSReadline (Power…
5733fc7 
…Shell#3626)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL