FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change error message when using New-Item to create a symlink and the item exists by jeffbi · Pull Request #3703 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Change error message when using New-Item to create a symlink and the item exists - #3703

Merged
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
jeffbi:bad-error-3700
May 5, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Change error message when using New-Item to create a symlink and the item exists#3703
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
jeffbi:bad-error-3700

Conversation

jeffbi commented May 5, 2017 •
edited by daxian-dbw
Loading

Copy link
Copy Markdown

Fix #3700
Improves the error displayed when attempting to create a SymbolicLink and the item named in -Path already exists.

Also changed the ErrorId to "SymLinkExists" to better identify the error.

Change error message when using New-Item to create a symlink and the …
115c664 
…item exists (#3700)

Also changed the ErrorId to "SymLinkExists".
Ilya (iSazonov) reviewed May 5, 2017
View reviewed changes
Comment thread src/System.Management.Automation/resources/FileSystemProviderStrings.resx Outdated
<data name="ItemExists" xml:space="preserve">
<value>Item '{0}' already exists.</value>
</data>
</root> No newline at end of file

Ilya (iSazonov) May 5, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add Newline.

jeffbi May 5, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed

Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated
$link.LinkType | Should BeExactly "SymbolicLink"
$link.Target | Should Be $nonFile
}
It "New-Item fails informatively when reversing Path and Target" {

Ilya (iSazonov) May 5, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please make the title more clear.

jeffbi May 5, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed

Made test title more clear.
ad4b5f2 
Added newline to end of resource file.
Ilya (iSazonov) reviewed May 5, 2017
View reviewed changes
Comment thread src/System.Management.Automation/resources/FileSystemProviderStrings.resx Outdated
</data>
</root> No newline at end of file
<data name="ItemExists" xml:space="preserve">
<value>Item '{0}' already exists.</value>

Ilya (iSazonov) May 5, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe use the pattern from tests - "Path {0} to symbolic link already exists." ?

jeffbi May 5, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about "The path {0} already exists."? That's similar to the error message when New-Item attempts to create a file that already exists, substituting "path" for "file".

I think that "Path {0} to symbolic link..." suggests that the existing item is itself a symbolic link, which is not necessarily the case.

Ilya (iSazonov) May 5, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In this context we should mention "symbolic link".
Maybe "Cannot create symbolic link because the path {0} already exists."

jeffbi May 5, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like that one. Fixed.

I also changed the name of the new string, to be a bit more clear about its use.

Ilya (iSazonov) commented May 5, 2017

Copy link
Copy Markdown
Collaborator

LGTM.

Dongbo Wang (daxian-dbw) changed the title Change error message when using New-Item to create a symlink and the item exists (#3700) Change error message when using New-Item to create a symlink and the item exists May 5, 2017
Dongbo Wang (daxian-dbw) merged commit 938e136 into PowerShell:master May 5, 2017

jeffbi commented May 5, 2017

Copy link
Copy Markdown
Author

Ilya (@iSazonov) Thanks for the review!

jeffbi deleted the bad-error-3700 branch May 8, 2017 04:55
jeffbi restored the bad-error-3700 branch May 8, 2017 05:01
jeffbi deleted the bad-error-3700 branch May 8, 2017 05:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Change error message when using New-Item to create a symlink and the …
cdf205a 
…item exists (PowerShell#3703)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ilya (iSazonov) iSazonov left review comments
Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL