key = Console.ReadKey(options.HasFlag(NoEcho))?

fixed

Actually, we should avoid HasFlag, because it's much, much more expensive than a simple bitwise test. HasFlag calls into a native implementation -- see the implementation here: https://github.com/dotnet/coreclr/blob/e67851210d1c03d730a3bc97a87e8a6713bbf772/src/vm/reflectioninvocation.cpp#L3699

Could you please remove the extra empty line?

Please avoid the use of the HasFlag api - it is much, much slower than the simple bit test - see the implementation here. The expensive part is mostly boxing, but you can see it does other work before the simple bitwise test.

it would be better to get uniform input - one person's opinion vs another. My original code was requested to change to this

Sorry, I don't see that feedback, so I can't comment on that.

It's not an opinion that the api is significantly slower, e.g. see here - that's the second hit for me on this search

My preference is to avoid the api completely because:

1. We do have places where the api would make PowerShell measurably slower
2. People working in our code base should be comfortable reading and writing code that is equivalent to this api
3. People tend to copy the style, so avoiding the api helps avoid usage creeping into places that matter.

Again, this is just feedback - I'm not blocking the PR.

i agree completely, there's even an open issue in corefx (https://github.com/dotnet/corefx/issues/15453). My original code did not use hasflag, which I will put back.