Removed import-module $helperModule as it is not needed. - #3814
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoMay 19, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
$helperModule is not defined anymore after refactoring changes. Import-Module is not necessary, hence removed. This is was not caught by CI as these are Feature tests.
Aditya Patwardhan (adityapatwardhan)
requested a review
from Dongbo Wang (daxian-dbw)
May 18, 2017 23:40
Copy link
Copy Markdown
Member
Author
|
Dongbo Wang (@daxian-dbw) Can you have a look? This is breaking daily build. |
Sorry, something went wrong.
Steve Lee (SteveL-MSFT)
approved these changes
May 19, 2017
Steve Lee (SteveL-MSFT)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Ilya (iSazonov)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Ilya (iSazonov)
approved these changes
May 19, 2017
Copy link
Copy Markdown
Member
Author
|
@PowerShell/powershell-maintainers This is ready to merge. This fixes the daily build. |
Sorry, something went wrong.
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$helperModule is not defined anymore after refactoring changes. Import-Module is not necessary, hence removed.
This is was not caught by CI as these are Feature tests.
This caused the daily build to be broken.
Related to changes done in: #3456