Fix non-fatal pester test failures - #3968
Merged
Jason Shirk (lzybkr) merged 1 commit intoJun 9, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ut making it hard to determine what tests actually failed
Steve Lee (SteveL-MSFT)
requested review from
James Truher (JamesWTruher) and
Ilya (iSazonov)
June 8, 2017 00:25
Ilya (iSazonov)
approved these changes
Jun 8, 2017
Ilya (iSazonov)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Mike Richmond (@mirichmo) can you merge? |
Sorry, something went wrong.
Jason Shirk (lzybkr)
approved these changes
Jun 9, 2017
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On another PR, I see a bunch of red error messages, but they appear to not actually fail the tests, but makes it hard to determine what actually failed. Cleaned up the tests. It appears that with the refactoring of the test modules, some lines of code were missed. There were also cut and paste issues in the test code so cleanup doesn't happen correctly.