FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove ClrVersion property from $PSVersionTable by SteveL-MSFT · Pull Request #4027 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Remove ClrVersion property from $PSVersionTable - #4027

Merged
Mike Richmond (mirichmo) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:clrversion
Jun 19, 2017
ConversationCommits (4)ChecksFiles changed
Merged

Remove ClrVersion property from $PSVersionTable#4027
Mike Richmond (mirichmo) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:clrversion

Conversation

Steve Lee (SteveL-MSFT) commented Jun 15, 2017

Copy link
Copy Markdown
Member

The ClrVersion property of $PSVersionTable is not useful with CoreCLR and end users should not be using
that value to determine compatibility. Recommendation from dotnet team is to remove that property.

Fix #1395

ClrVersion property of $PSVersionTable is not useful with CoreCLR and…
645c875 
… end users should not be using

that value to determine compatibility.  Recommendation from dotnet team is to remove that property.
Jason Shirk (lzybkr) added the Breaking-Change breaking change that may affect users label Jun 16, 2017
Ilya (iSazonov) reviewed Jun 16, 2017
View reviewed changes

Ilya (iSazonov) left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I believe we should remove internal static Version CLRVersion and internal const string PSCLRVersionName

Steve Lee (SteveL-MSFT) commented Jun 16, 2017

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) will remove those

Ilya (iSazonov) commented Jun 16, 2017

Copy link
Copy Markdown
Collaborator

LGTM.

Steve Lee (SteveL-MSFT) commented Jun 19, 2017

Copy link
Copy Markdown
Member Author

Mike Richmond (@mirichmo) can you merge?

Mike Richmond (mirichmo) reviewed Jun 19, 2017
View reviewed changes
Comment thread src/System.Management.Automation/engine/PSVersionInfo.cs
}
}

internal static Version CLRVersion

Mike Richmond (mirichmo) Jun 19, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What is our stance on removing FullCLR compatibility of the code? If we are dropping that requirement and only focusing on CoreCLR, then you should remove PSCLRVersionName from line 77 as well.

Steve Lee (SteveL-MSFT) Jun 19, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed it since we removed the other members anyways. After beta.3 goes out, I intend to revisit the discussion about removing FullCLR code.

Mike Richmond (mirichmo) merged commit a66cd0b into PowerShell:master Jun 19, 2017
Steve Lee (SteveL-MSFT) deleted the clrversion branch June 28, 2017 21:19
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Remove ClrVersion property from $PSVersionTable (PowerShell#4027)
92f1330 
* ClrVersion property of $PSVersionTable is not useful with CoreCLR and end users should not be using it
that value to determine compatibility.  Recommendation from dotnet team is to remove that property.

* Removed internal members used for CLRVersion

* removed CLRVersion from FullCLR build as well

* added additional information to run `start-psbootstrap -buildnative` if cmake is not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
Mike Richmond (mirichmo) mirichmo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Mike Richmond (mirichmo)

Labels

Breaking-Change breaking change that may affect users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL