Close eventLogSession and EventLogReader to unlock an etl file - #4034
Merged
Jason Shirk (lzybkr) merged 2 commits intoJul 7, 2017
Merged
Close eventLogSession and EventLogReader to unlock an etl file#4034Jason Shirk (lzybkr) merged 2 commits into
Jason Shirk (lzybkr) merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
src/Microsoft.PowerShell.Commands.Diagnostics/GetEventCommand.cs
Outdated
| { | ||
| try | ||
| if (readerObj != null) | ||
| { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This test isn't necessary - new would throw an exception or return non-null.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Fixed.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Jason Shirk (@lzybkr) Could you please continue the code review? |
Sorry, something went wrong.
Jason Shirk (lzybkr)
approved these changes
Jul 7, 2017
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3979
No tests and documentation required.