FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for implicit remote regression in restricted session by PaulHigin · Pull Request #4222 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fix for implicit remote regression in restricted session - #4222

Merged
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
PaulHigin:ImplicitRemoteBug
Jul 14, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Fix for implicit remote regression in restricted session#4222
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
PaulHigin:ImplicitRemoteBug

Conversation

Paul Higinbotham (PaulHigin) commented Jul 11, 2017

Copy link
Copy Markdown
Contributor

Issue #4195

PowerShell 5.1 Get-FormatData has a new required parameter (PowerShellVersion) which was not included in restricted sessions. So Import-PSSession fails when trying to use the parameter.

Fix is to add this parameter to the restricted session Get-FormatData proxy function.

Repro:

# Create and register a restricted session endpoint on local machine with PS 5.1
New-PSSessionConfigurationFile -Path c:\restricted.pssc -SessionType RestrictedRemoteServer
Register-PSSessionConfiguration -Path C:\restricted.pssc -Name restricted -Force
 
# Create and import a session instance
$s = New-PSSession -config restricted 
Import-PSSession -Session $s -AllowClobber
 
Result:
Import-PSSession : Running the Get-Command command in a remote session reported the following error: A parameter
cannot be found that matches parameter name 'PowerShellVersion'..
At line:1 char:1
+ Import-PSSession -Session $s -AllowClobber
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidResult: (:) [Import-PSSession], RuntimeException
    + FullyQualifiedErrorId : ErrorFromRemoteCommand,Microsoft.PowerShell.Commands.ImportPSSessionCommand

Paul Higinbotham (PaulHigin) added WG-Remoting PSRP issues with any transport layer Issue-Bug Issue has been identified as a bug in the product OS-Windows labels Jul 11, 2017
Paul Higinbotham (PaulHigin) added this to the 6.0.0-HighPriority milestone Jul 11, 2017

Paul Higinbotham (PaulHigin) commented Jul 11, 2017

Copy link
Copy Markdown
Contributor Author

There is no test associated with this fix because we have not ported implicit remoting tests yet.
I have created Issue #4223 to track this.

Dongbo Wang (daxian-dbw) commented Jul 13, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) we have implicit remoting tests at https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Utility/Implicit.Remoting.Tests.ps1
Can you please take a look to see if that's what you looked for?
If it is, could you please add the corresponding tests for this PR as well?

Paul Higinbotham (PaulHigin) commented Jul 14, 2017

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Thanks!, I didn't realize these tests were ported. I'll create a test for this fix.

Dongbo Wang (daxian-dbw) reviewed Jul 14, 2017
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Implicit.Remoting.Tests.ps1 Outdated

if ($originalDefaultParameters -ne $null)
{
$PSDefaultParameterValues = $originalDefaultParameters

Dongbo Wang (daxian-dbw) Jul 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should be $global:PSDefaultParameterValues = $originalDefaultParameters. Otherwise, you are just defining a variable in the local scope.

Travis Plunk (TravisEz13) commented Jul 14, 2017

Copy link
Copy Markdown
Member

restarted AppVeyor CI due to MyGet failure

Dongbo Wang (daxian-dbw) merged commit 7fa0dd0 into PowerShell:master Jul 14, 2017
Paul Higinbotham (PaulHigin) deleted the ImplicitRemoteBug branch July 14, 2017 19:30
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Fix for implicit remote regression in restricted session (PowerShell#…
ab657fa 
…4222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
Travis Plunk (TravisEz13) TravisEz13 approved these changes

Assignees

Mike Richmond (mirichmo)

Labels

Issue-Bug Issue has been identified as a bug in the product OS-Windows WG-Remoting PSRP issues with any transport layer

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL