FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable DataRow/DataRowView adapters in PowerShell Core by daxian-dbw · Pull Request #4258 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Enable DataRow/DataRowView adapters in PowerShell Core - #4258

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
daxian-dbw:adapters
Jul 17, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Enable DataRow/DataRowView adapters in PowerShell Core#4258
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
daxian-dbw:adapters

Conversation

Dongbo Wang (daxian-dbw) commented Jul 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Fix #4232

Enable the DataRow/DataRowView adapters in PowerShell Core by moving the implementation from ExtraAdapter.cs to CoreAdapter.cs.
Add basic tests too.

Travis Plunk (TravisEz13) reviewed Jul 17, 2017
View reviewed changes
Comment thread src/System.Management.Automation/engine/CoreAdapter.cs
/// <summary>
/// Deals with DataRow objects
/// </summary>
internal class DataRowAdapter : PropertyOnlyAdapter

Travis Plunk (TravisEz13) Jul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why don't we follow the one class per file practice?

Dongbo Wang (daxian-dbw) Jul 17, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Core adapters have always been in the same file. Some of them were moved to ExtraAdapter.cs previously due to missing the corresponding type in CoreCLR. Now we are gradually moving them back.

Travis Plunk (TravisEz13) Jul 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The question is more about the project in general.

Dongbo Wang (daxian-dbw) merged commit 069c7a4 into PowerShell:master Jul 17, 2017
Dongbo Wang (daxian-dbw) deleted the adapters branch July 17, 2017 18:27

Maximo Trinidad (MaximoTrinidad) commented Jul 17, 2017

Copy link
Copy Markdown

Hi Dongbo Wang (@daxian-dbw)

Any idea when can I test this change? Looking forward to give it a shot.
:)

Thanks,

Dongbo Wang (daxian-dbw) commented Jul 17, 2017

Copy link
Copy Markdown
Member Author

Maximo Trinidad (@MaximoTrinidad) The release of beta.5 will on 8/3. But you can build powershell locally to verify the fix.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Enable DataRow/DataRowView adapters in PowerShell Core (PowerShell#4258)
5d39f5e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Travis Plunk (TravisEz13) TravisEz13 approved these changes

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL