Tests for New-WinEvent by anmenaga · Pull Request #4384 · PowerShell/PowerShell · GitHub

Some tests for New-WinEvent that bring code coverage of the class to 80%.

You may want to use $PSDefaultParameterValues to set the value of skip.

Yup, I saw that approach; but don't really like it; I think having skip conditions explicitly on each test makes it easier to investigate test failures.

The recommendation according to the testing guidelines is to use PSDefaultParameterValues. Please see: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/WritingPesterTests.md

Updated.

Should be,

(Get-WinEvent -filterHashtable $filter).Count | Should BeGreaterThan 0

Updated.

Typo. Please change "ShouldBeErrorID" -> "ShouldBeErrorId".

Updated.

Please move the comment on separate line.

Moved.

Move the comment to a separate line.

updated.

Which issue does this address if any?

use something like

$PSProviderId = 40962

Updated.

This goes toward #4156

Based on the code coverage, you're missing some tests:
https://codecov.io/gh/PowerShell/PowerShell/src/9e41c647a9407e05d86f4971a6bd25719a7130d0/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/EventDescriptor.cs

EventDescriptor constructor validation like: [System.Diagnostics.Eventing.EventDescriptor]::new(-1, 0, 0, 0, 0, -1, 0)
Reading back members of EventDescriptor
https://codecov.io/gh/PowerShell/PowerShell/src/9e41c647a9407e05d86f4971a6bd25719a7130d0/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/EventProvider.cs
Dispose(), Close(), destructor
IsEnabled()
different data types
WriteMessagEvent()
WriteEvent
WriteTransferEvent
https://codecov.io/gh/PowerShell/PowerShell/src/9e41c647a9407e05d86f4971a6bd25719a7130d0/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/EventProviderTraceListener.cs
EventProviderTraceListener

The Reader code should probably be a different PR

Steve Lee (@SteveL-MSFT) All of the things that you've mentioned is ETW code and will go into separate PR.
This PR is specific to New-WinEvent cmdlet code.

Ilya (@iSazonov) Can you have a look again?

I believe we can remove the comment. And maybe move to the test name.

Andrew (@anmenaga) can you address this?

Updated.

With one minor comment LGTM.

* New-WinEvent tests * PR feedback * PR feedback 2 * PR feedback 3 * PR feedback 4 * PR feedback 5

New-WinEvent tests

72cca70

Andrew (anmenaga) requested a review from Steve Lee (SteveL-MSFT) July 28, 2017 22:24

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 28, 2017

Aditya Patwardhan (adityapatwardhan) requested changes Jul 28, 2017

View reviewed changes

Ilya (iSazonov) reviewed Jul 31, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Jul 31, 2017

Andrew added 2 commits July 31, 2017 16:19

PR feedback

6411500

PR feedback 2

7da758f

Aditya Patwardhan (adityapatwardhan) requested changes Aug 1, 2017

View reviewed changes

Steve Lee (SteveL-MSFT) requested changes Aug 1, 2017

View reviewed changes

PR feedback 3

fe2df53

PR feedback 4

b3d408c

Aditya Patwardhan (adityapatwardhan) approved these changes Aug 1, 2017

View reviewed changes

Steve Lee (SteveL-MSFT) approved these changes Aug 2, 2017

View reviewed changes

Ilya (iSazonov) reviewed Aug 4, 2017

View reviewed changes

PR feedback 5

6d8d616

Aditya Patwardhan (adityapatwardhan) approved these changes Aug 4, 2017

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit 0b7451b into PowerShell:master Aug 7, 2017

Andrew (anmenaga) deleted the NewWinEventTests branch October 31, 2018 21:19

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Tests for New-WinEvent (PowerShell#4384 )

ee905c6

* New-WinEvent tests * PR feedback * PR feedback 2 * PR feedback 3 * PR feedback 4 * PR feedback 5

+                      It 'Simple New-WinEvent' -Skip:(-not $IsWindows) {
+                          New-WinEvent -ProviderName Microsoft-Windows-PowerShell -Id 40962 -Version 1 # simple event without any payload
+                          $filter = @{ ProviderName = 'Microsoft-Windows-PowerShell'; Id = 40962}
+                          (Get-WinEvent -filterHashtable $filter).Count -gt 0 | Should be $true


		Context "New-WinEvent tests" {

		It 'Simple New-WinEvent' -Skip:(-not $IsWindows) {

+                      }
+                      It 'No provider found error' -Skip:(-not $IsWindows) {
+                          { New-WinEvent -ProviderName NonExistingProvider -Id 0 } | ShouldBeErrorID 'System.ArgumentException,Microsoft.PowerShell.Commands.NewWinEventCommand'

+                      It 'PayloadMismatch error' -Skip:(-not $IsWindows) {
+                          $logPath = join-path $TestDrive 'testlog1.txt'
+                          New-WinEvent -ProviderName Microsoft-Windows-PowerShell -Id 32868 *> $logPath # this will print the warning with expected event template to the file

Tests for New-WinEvent by anmenaga · Pull Request #4384 · PowerShell/PowerShell · GitHub

Uh oh!

Tests for New-WinEvent - #4384

Tests for New-WinEvent#4384Aditya Patwardhan (adityapatwardhan) merged 6 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom anmenaga:NewWinEventTestsanmenaga/PowerShell:NewWinEventTestsCopy head branch name to clipboard

Conversation

Andrew (anmenaga) commented Jul 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andrew (anmenaga) commented Aug 1, 2017

Uh oh!

Steve Lee (SteveL-MSFT) commented Aug 2, 2017

Uh oh!

Andrew (anmenaga) commented Aug 2, 2017

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Aug 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Aug 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Tests for New-WinEvent#4384
Aditya Patwardhan (adityapatwardhan) merged 6 commits into
PowerShell:masterfrom
anmenaga:NewWinEventTests