Improve test coverage for CDXML cmdlet infrastructure by JamesWTruher · Pull Request #4537 · PowerShell/PowerShell · GitHub

address issue #4159

Create custom cim classes (via MOF) and cdxml cmdlets against the new cim class
Create tests for CRUD operations for CDXML cmdlets
Coverage for Microsoft.PowerShell.Cmdletization namespace is nearly 50%

Includes MOF files to create and delete class and instances which are used by the tests

updated create mof file to support associations as well as complex objects updated delete mof file to remove all classes added an enum to cdxml (not yet used) updated psd1 to export new cmdlets for set and new

LGTM with minor comments

Please use ForEach-Object instead of %

This needs to be addressed.
As stated in #3791, our scripts should not have PSScriptAnalyzer warnings and errors.

fixed

Use Where-Object instead of ?

Same here.

fixed

Extra line.

Remove extra lines.

fixed

Do we need this? This probably points to something else.

probably not - removed

Why not use a direct $IsWindows test versus a variable?

I thought it was clearer here -skip (I've seen other tests do exactly the opposite of what was wanted)

Why isn't this an outright failure? It appears to be masking a bug.

I thought about this, and while it might be a bug in the mof file or a problem with mofcomp, marking a test as pending doesn't get us off the hook - all pending tests must be resolved before we ship (and I do track our pending tests). However, I didn't want to invalidate the build because I couldn't even get to the actual test. I thought it was better to mark the test as pending rather than fail.

Why isn't Wait-Job -Timeout sufficient?

ahem, yes, that's much better
-fixed-

If there is a problem with mofcomp execution, the tests will fail rather than being marked as pending (feedback from DanTra) use cmdlet names rather than aliases for foreach-object and where-object Script analyzer report is clean Also remove unneeded empty lines and helpinfouri from psd1 file

Dan Travison (@dantraMSFT), I believe this is ok now

Dan Travison (@dantraMSFT) Can you please take another look at this PR?

Create custom CIM classes (via MOF) and CDXML cmdlets against the new CIM class Create tests for CRUD operations for CDXML cmdlets Coverage for Microsoft.PowerShell.Cmdletization namespace is nearly 50%

James Truher (JamesWTruher) added 3 commits August 9, 2017 13:46

Simple CDXML tests for Get and Remove

f624d07

Includes MOF files to create and delete class and instances which are used by the tests

Additional tests - All CRUD operations are now covered

6f09fe6

updated create mof file to support associations as well as complex objects updated delete mof file to remove all classes added an enum to cdxml (not yet used) updated psd1 to export new cmdlets for set and new

Add tests for exceptions and support whatif

5279b03

James Truher (JamesWTruher) assigned Dongbo Wang (daxian-dbw) Aug 9, 2017

James Truher (JamesWTruher) requested review from Aditya Patwardhan (adityapatwardhan) and Dan Travison (dantraMSFT) August 9, 2017 20:59

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 9, 2017

Aditya Patwardhan (adityapatwardhan) approved these changes Aug 11, 2017

View reviewed changes

Dan Travison (dantraMSFT) reviewed Aug 14, 2017

View reviewed changes

Dan Travison (dantraMSFT) approved these changes Aug 16, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) merged commit 0d1e191 into PowerShell:master Aug 16, 2017

James Truher (JamesWTruher) deleted the jameswtruher/cdxmltest001 branch May 11, 2022 16:35

+                  Context "Remove-CimTest cmdlet" {
+                      BeforeEach {
+                          Get-CimTest | Remove-CimTest
+..4 | %{ New-CimInstance -namespace root/default -class PSCore_Test1 -property @{

+                  AliasesToExport = @()
+                  CmdletsToExport = @()
+                  FunctionsToExport = @( 'Get-CimTest', 'Remove-CimTest', 'New-CimTest', 'Set-CimTest' )
+                  HelpInfoUri = "https://go.microsoft.com/fwlink/?linkid=390832"

+              Describe "Cdxml cmdlets are supported" -Tag CI,RequireAdminOnWindows {
+                  BeforeAll {
+                      $skipNotWindows = ! $IsWindows
+                      if ( $skipNotWindows ) {

+                              $job = Get-CimTest -id 3 | Remove-CimTest -asjob
+                              $result = $null
+                              $i = 0
+                              # wait up to 10 seconds, then the test will fail

+                              field2 = 0
+                          }
+                          New-CimTest @instanceArgs
+                          $result = Get-CimInstance -namespace root/default -class PSCore_Test1 | ?{$_.id -eq "telephone"}

+                          $result.field2 | should be 33
+                      }
+                  }

		HelpInfoUri = "https://go.microsoft.com/fwlink/?linkid=390832"
		}

+                          }
+                          $result = MofComp.exe $deleteMof
+                          if ( $LASTEXITCODE -ne 0 ) {
+                              $script:ItSkipOrPending = @{ Pending = $true }

Improve test coverage for CDXML cmdlet infrastructure by JamesWTruher · Pull Request #4537 · PowerShell/PowerShell · GitHub

Uh oh!

Improve test coverage for CDXML cmdlet infrastructure - #4537

Improve test coverage for CDXML cmdlet infrastructure #4537Dongbo Wang (daxian-dbw) merged 4 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom JamesWTruher:jameswtruher/cdxmltest001JamesWTruher/PowerShell-1:jameswtruher/cdxmltest001Copy head branch name to clipboard

Conversation

James Truher (JamesWTruher) commented Aug 9, 2017

Uh oh!

Aditya Patwardhan (adityapatwardhan) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Aug 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

James Truher (JamesWTruher) commented Aug 15, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Aug 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Improve test coverage for CDXML cmdlet infrastructure #4537
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
JamesWTruher:jameswtruher/cdxmltest001

Dongbo Wang (daxian-dbw) Aug 12, 2017 •
edited
Loading