FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add codeowner files by TravisEz13 · Pull Request #4565 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Add codeowner files - #4565

Merged
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
TravisEz13:AddOwnership
Aug 15, 2017
ConversationCommits (5)ChecksFiles changed
Merged

Add codeowner files#4565
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
TravisEz13:AddOwnership

Conversation

Travis Plunk (TravisEz13) commented Aug 12, 2017

Copy link
Copy Markdown
Member

add codeowner file to automatically assign reviewers and to describe who owns areas.

Ilya (iSazonov) reviewed Aug 12, 2017
View reviewed changes

Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nicks should be fixed in all file.

Comment thread .github/CODEOWNERS Outdated
# @daxian-dbw @lzybkr @steveL-MSFT @charub

# Area: Language
# daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT

Ilya (iSazonov) Aug 12, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

daxian-dbw -> @daxian-dbw

Comment thread .github/CODEOWNERS Outdated
# First Lets start with areas with no filters or paths

# Area: Performance
# @lzybkr @steveL-MSFT @adityapatwardhan

Ilya (iSazonov) Aug 12, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@steveL-MSFT -> @SteveL-MSFT

Comment thread .github/CODEOWNERS Outdated
# @BrucePay @JamesWTruher @steveL-MSFT

# Area: Security
# @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen

Ilya (iSazonov) Aug 12, 2017

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@travisez13 -> @TravisEz13

Travis Plunk (TravisEz13) commented Aug 13, 2017

Copy link
Copy Markdown
Member Author

I addressed Ilya (@iSazonov) 's feedback

Steve Lee (SteveL-MSFT) reviewed Aug 14, 2017
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
# @BrucePay @JamesWTruher @SteveL-MSFT

# Area: Security
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen

Steve Lee (SteveL-MSFT) Aug 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You should remove Lee and Chunqing

Steve Lee (SteveL-MSFT) requested changes Aug 14, 2017
View reviewed changes

Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You should remove my name from everywhere except demos.

Travis Plunk (TravisEz13) commented Aug 14, 2017

Copy link
Copy Markdown
Member Author

Steve Lee (@SteveL-MSFT) Updated

Aditya Patwardhan (adityapatwardhan) requested changes Aug 14, 2017
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin

# Area: help
src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan

Aditya Patwardhan (adityapatwardhan) Aug 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Francisco Gamino (@Francisco-Gamino) -> Francisco Gamino (@Francisco-Gamino)

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#Resolved

Comment thread .github/CODEOWNERS Outdated

# Area: Debugging
# Must be below engine to override
src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin

Aditya Patwardhan (adityapatwardhan) Aug 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Space between Bruce Payette (@BrucePay) and Dan Travison (@dantraMSFT)

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Resolved

Steve Lee (SteveL-MSFT) requested changes Aug 14, 2017
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

# Area: Security
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen
# @TravisEz13 @leeholmes @PaulHigin @chunqingchen

Steve Lee (SteveL-MSFT) Aug 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

remove leeholmes, he isn't generally available so Paul, Travis, or I will pull him in when needed. Remove chunqing

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#Resolved

Dan Travison (dantraMSFT) reviewed Aug 15, 2017
View reviewed changes
Comment thread .github/CODEOWNERS Outdated
demos/ @joeyaiello @SteveL-MSFT @HemantMahawar

# Area: DSC
src/System.Management.Automation/DscSupport @TravisEz13

Dan Travison (dantraMSFT) Aug 15, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can add dantraMSFT to DSC as well.

Travis Plunk (TravisEz13) Aug 15, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added

Ilya (iSazonov) commented Aug 15, 2017

Copy link
Copy Markdown
Collaborator

Travis CI temporary failed - I restarted it.

Aditya Patwardhan (adityapatwardhan) approved these changes Aug 15, 2017
View reviewed changes

Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Travis Plunk (TravisEz13) merged commit 498680a into PowerShell:master Aug 15, 2017

Dongbo Wang (daxian-dbw) commented Aug 15, 2017

Copy link
Copy Markdown
Member

+test/ @JamesWTruher @TravisEz13 @adityapatwardhan

Just realized that this cause Jim, Travis and Aditya to be dragged into almost every PR review.
Maybe we shouldn't specify 'test/' in the codeowner file.

Travis Plunk (TravisEz13) commented Aug 15, 2017

Copy link
Copy Markdown
Member Author

Rules later in the file are supposed to override previous rules. Let's see how it actually works before we change it.

Travis Plunk (TravisEz13) commented Aug 15, 2017

Copy link
Copy Markdown
Member Author

But looking at least one PR it looks like it takes the aggregate of what it finds from the rules. Do you want me to submit a PR removing the area-test rule?

Travis Plunk (TravisEz13) deleted the AddOwnership branch September 27, 2017 18:57
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Add codeowner files (PowerShell#4565)
a25416f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ilya (iSazonov) iSazonov left review comments
Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
Mike Richmond (mirichmo) Awaiting requested review from mirichmo
sergei (vors) Awaiting requested review from vors
+1 more reviewer
Dan Travison (dantraMSFT) dantraMSFT left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL