Package only from root plus powershell - #4569
Conversation
Sorry, something went wrong.
| Write-Warning "Skipping release checks." | ||
| } | ||
|
|
||
| if(!$Script:Options.RootInfo.IsValid -and -not $SkipReleaseChecks.IsPresent){ |
There was a problem hiding this comment.
an elseif is better here.
elseif (!$Script:Options.RootInfo.IsValid) {
throw $Script:Options.RootInfo.Warning
}
Sorry, something went wrong.
There was a problem hiding this comment.
Resolved
Sorry, something went wrong.
| { | ||
| $RootInfo += @{Warning = "Please ensure you repo is at the root of the file system and named 'PowerShell' (example: '$($RootInfo.ValidPath)'), when building and packaging for release!" } | ||
| $RootInfo += @{IsValid = $false} | ||
| Write-Warning -Message $RootInfo.Warning |
There was a problem hiding this comment.
Don't write the warning in New-PSOptions. We only care about the root path when it comes to a release build.
Sorry, something went wrong.
There was a problem hiding this comment.
Resolved
Sorry, something went wrong.
| $packages += Start-PSPackage @packageParams -Type AppImage | ||
| $packages = @(Start-PSPackage @packageParams -SkipReleaseChecks) | ||
| # Packaging AppImage depends on the deb package | ||
| $packages += Start-PSPackage @packageParams -Type AppImage -SkipReleaseChecks |
There was a problem hiding this comment.
There is an extra space before -SkipReleaseChecks, in both line 182 and 184
Sorry, something went wrong.
There was a problem hiding this comment.
Resolved
Sorry, something went wrong.
| $RootInfo = @{RepoPath = $PSScriptRoot} | ||
|
|
||
| # the valid root is the root of the filesystem and the folder PowerShell | ||
| $RootInfo += @{ValidPath = Join-Path -Path ([system.io.path]::GetPathRoot($RootInfo.RepoPath)) -ChildPath 'PowerShell' } |
There was a problem hiding this comment.
A minor comment about the way you use Hashtable: in this scenario it's better to write script like
$RootInfo['ValidPath'] = Join-Path -Path ([system.io.path]::GetPathRoot($RootInfo.RepoPath)) -ChildPath 'PowerShell' $RootInfo['IsValid'] = $true $RootInfo['Warning'] = "Please ensure you repo is at the root of the file system and named 'PowerShell' (example: '$($RootInfo.ValidPath)'), when building and packaging for release!"
It's much less expensive than adding two hashtables.
Sorry, something went wrong.
fixes #4492