Updated default ModuleVersion in ModuleManifest - #4842
Updated default ModuleVersion in ModuleManifest#4842Aditya Patwardhan (adityapatwardhan) merged 2 commits into
Conversation
Sorry, something went wrong.
|
@LDSpits, It will cover your contributions to all Microsoft-managed open source projects. |
Sorry, something went wrong.
|
Lucas Spits (@LDSpits), thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Sorry, something went wrong.
| new UTF8Encoding(false), // UTF-8, no BOM | ||
| #else | ||
| EncodingConversion.Unicode, // UTF-16 with BOM | ||
| #endif |
There was a problem hiding this comment.
Is this part of change caused by some character encoding? If no intentional change was made, you can get rid of it by using git reset HEAD^ and then git add -p (ignore this change section when adding).
Sorry, something went wrong.
There was a problem hiding this comment.
As part of #4761 (comment), this file has mixed EOL characters. We can accept it to make the EOLs the same for this file or ignore it as I'm fixing this across the entire codebase in a separate PR.
Sorry, something went wrong.
There was a problem hiding this comment.
OK, then we can accept this part of the changes.
Sorry, something went wrong.
Aditya Patwardhan (adityapatwardhan)
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
* Updated default ModuleVersion in ModuleManifest to 0.0.1 * updates tests where manifests default versions where still matched agianst the old 1.0 version
This pull request updates the New-ModuleManifest command to generate a ModuleVersion manifest property with 0.0.1 instead of 1.0. specified by the discussion in #4823.