Only display properties with values for MeasureInfo by powercode · Pull Request #7104 · PowerShell/PowerShell · GitHub

PR Summary

Adding Item selection conditions to the list formatting info for MeasureInfo so that only the properties with values gets displayed

Reopening #6214

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

This change is

…ition

From #6412 #6214 (comment)

@PowerShell/powershell-committeeTeam members are private reviewed this and is ok with the public apis

The build errors seems completely separate from my changes.
Ilya (@iSazonov) Can you restart the build?

Reopen the PR to restart CIs.

I don't intend to fix the remaining CodeFactor issues.

James Truher (@JamesWTruher) can you please take a look? Thx.

Jim is on a leave; + Steve Lee (@SteveL-MSFT) for review who is familiar with formatting APIs.

typo: itemSelectionCondition

LGTM

Seems we skipped

$text -match 'Sum' | Should -BeFalse

Staffan Gustafsson (@powercode) Please address the comment.

Bruce Payette (@BrucePay) Jason Shirk (@lzybkr) Please look the PR.

Staffan Gustafsson (@powercode) Thank you for the contribution!

I added "Documentation-Needed" label (if you can please open new issue in PowerShell-Docs repo).

Paul Higinbotham (@PaulHigin) should review this new public api for any security implications in creating script blocks that might circumvent the language mode.

Paul Higinbotham (@PaulHigin) reviewed this and told me he doesn't see a security issue. Paul Higinbotham (@PaulHigin) can you confirm?

Ilya (@iSazonov) we should revert this commit until security review of the public api has been completed

cc Travis Plunk (@TravisEz13)

…ll#7104)" This reverts commit 87ccd0a until security review of the public api has been completed.

Steve Lee (@SteveL-MSFT) Opened #7754.

…7754) This reverts commit 87ccd0a until security review of the public api has been completed.

…ll#7104)" (PowerShell#7754) This reverts commit 87ccd0a until security review of the public api has been completed.

* Adding support for built-in List formats to include ItemSelectionCondition * Adding ItemSelectionCondition to GenericMeasureInfo * Adding tests for MeasureInfo format-list * Adding positive tests

…ll#7104)" (PowerShell#7754) This reverts commit f657820 until security review of the public api has been completed.

Staffan Gustafsson and others added 6 commits June 18, 2018 23:11

Adding support for built-in List formats to include ItemSelectionCond…

8131fa1

…ition

Adding ItemSelectionCondition to GenericMeasureInfo

7906048

Adding tests for MeasureInfo format-list

bee583e

Addressing review comments

356faf9

fixing casing of Sum

f069ac4

Adding positive tests

2bb06fe

Ilya (iSazonov) added the Committee-Reviewed PS-Committee has reviewed this and made a decision label Jun 19, 2018

Ilya (iSazonov) requested review from James Truher (JamesWTruher) and Jason Shirk (lzybkr) June 19, 2018 03:49

Ilya (iSazonov) self-assigned this Jun 19, 2018

Ilya (iSazonov) closed this Jul 4, 2018

Ilya (iSazonov) reopened this Jul 4, 2018

Andrew (anmenaga) requested a review from Steve Lee (SteveL-MSFT) August 2, 2018 21:02

Steve Lee (SteveL-MSFT) requested changes Aug 9, 2018

View reviewed changes

Staffan Gustafsson (powercode) added 3 commits August 9, 2018 20:56

Fixing typo

42b4a68

Code factor fixes.

f6ffe1a

Yet another code factor.

f6d6633

Steve Lee (SteveL-MSFT) approved these changes Aug 16, 2018

View reviewed changes

Steve Lee (SteveL-MSFT) requested a review from Bruce Payette (BrucePay) August 16, 2018 18:23

Ilya (iSazonov) reviewed Aug 17, 2018

View reviewed changes

Adding missing testcase for Sum.

b424329

Staffan Gustafsson (powercode) force-pushed the formatting_ItemSelectionConditions branch from 1b4a460 to b424329 Compare August 27, 2018 19:45

Ilya (iSazonov) changed the title MeasureInfo: Only display properties with values Only display properties with values for MeasureInfo Aug 28, 2018

Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Aug 28, 2018

Ilya (iSazonov) merged commit 87ccd0a into PowerShell:master Aug 28, 2018

Jason Shirk (lzybkr) reviewed Aug 28, 2018

View reviewed changes

Staffan Gustafsson (powercode) mentioned this pull request Aug 28, 2018

Document ListEntryBuilder.AddItemScriptBlock with itemSelectionCondition MicrosoftDocs/PowerShell-Docs#2862

Closed

8 tasks

Travis Plunk (TravisEz13) mentioned this pull request Aug 28, 2018

Review change per PR comment post merge #7652

Closed

Ilya (iSazonov) added a commit to iSazonov/PowerShell that referenced this pull request Sep 11, 2018

Revert "Only display properties with values for MeasureInfo (PowerShe…

65babca

…ll#7104)" This reverts commit 87ccd0a until security review of the public api has been completed.

Ilya (iSazonov) mentioned this pull request Sep 11, 2018

Revert "Only display properties with values for MeasureInfo (#7104)" #7754

Merged

11 tasks

Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Oct 11, 2018

Revert "Only display properties with values for MeasureInfo (#7104 )" (#…

17fd2e9

…7754) This reverts commit 87ccd0a until security review of the public api has been completed.

Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018

Docs needed for 'Only display properties with values for MeasureInfo' MicrosoftDocs/PowerShell-Docs#3032

Closed

Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018

This was referenced May 24, 2019

Review PR to only show MeasureInfo with populated values for security concerns #9726

Closed

Test-Connection Changes PowerShell/PowerShell-RFC#172

Merged

+                          $text = 1, 2, 3 | Measure-Object -Minimum -Maximum | Format-List | Out-String
+                          $text -match "min" | Should -BeTrue
+                          $text -match "max" | Should -BeTrue
+                          $text -match 'Average' | Should -BeFalse

                       }
-                      private ListEntryBuilder AddItem(string value, string label, DisplayEntryValueType kind, string format)
+                      private ListEntryBuilder AddItem(string value, string label, DisplayEntryValueType kind, string format, DisplayEntry itemSelectionContition)

                       /// <summary></summary>
-                      public ListEntryBuilder AddItemScriptBlock(string scriptBlock, string label = null, string format = null)
+                      public ListEntryBuilder AddItemScriptBlock(string scriptBlock, string label = null, string format = null, DisplayEntry itemSelectionContition = null)

                       /// <summary></summary>
-                      public ListEntryBuilder AddItemProperty(string property, string label = null, string format = null)
+                      public ListEntryBuilder AddItemProperty(string property, string label = null, string format = null, DisplayEntry itemSelectionContition = null)

+                      /// <summary></summary>
+                      public ListEntryBuilder AddItemPropertyIfSet(string property, string label = null, string format = null)
+                      {
+                          var itemSelectionContition = DisplayEntry.CreatePropertyEntry(property);

+                      /// <returns>A <see cref="DisplayEntry"/> for the <paramref name="scriptblock"/>.</returns>
+                      public static DisplayEntry CreateScriptBlockEntry(string scriptblock)
+                      {
+                          return new DisplayEntry(scriptblock, DisplayEntryValueType.ScriptBlock);

Only display properties with values for MeasureInfo by powercode · Pull Request #7104 · PowerShell/PowerShell · GitHub

Uh oh!

Only display properties with values for MeasureInfo - #7104

Only display properties with values for MeasureInfo#7104Ilya (iSazonov) merged 10 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom powercode:formatting_ItemSelectionConditionspowercode/PowerShell:formatting_ItemSelectionConditionsCopy head branch name to clipboard

Conversation

Staffan Gustafsson (powercode) commented Jun 18, 2018 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Ilya (iSazonov) commented Jun 19, 2018

Uh oh!

Staffan Gustafsson (powercode) commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jul 4, 2018

Uh oh!

Staffan Gustafsson (powercode) commented Jul 4, 2018

Uh oh!

Andrew (anmenaga) commented Jul 13, 2018

Uh oh!

Andrew (anmenaga) commented Aug 2, 2018

Uh oh!

Steve Lee (SteveL-MSFT) Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Aug 27, 2018

Uh oh!

Ilya (iSazonov) commented Aug 28, 2018

Uh oh!

Jason Shirk (lzybkr) Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Jun 10, 2019

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Sep 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Only display properties with values for MeasureInfo#7104
Ilya (iSazonov) merged 10 commits into
PowerShell:masterfrom
powercode:formatting_ItemSelectionConditions

Staffan Gustafsson (powercode) commented Jun 18, 2018 •
edited by iSazonov
Loading

Staffan Gustafsson (powercode) commented Jul 4, 2018 •
edited
Loading

Ilya (iSazonov) Aug 17, 2018 •
edited
Loading

Steve Lee (SteveL-MSFT) commented Sep 10, 2018 •
edited
Loading