FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Get-ChildItem -Path with wildcard char by kwkam · Pull Request #7403 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Fix Get-ChildItem -Path with wildcard char - #7403

Closed
kwkam wants to merge 1 commit into
PowerShell:masterfrom
kwkam:wc-getchild
ConversationCommits (1)ChecksFiles changed
Closed

Fix Get-ChildItem -Path with wildcard char#7403
kwkam wants to merge 1 commit into
PowerShell:masterfrom
kwkam:wc-getchild

Conversation

kwkam commented Jul 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Unescape non-literal, non-glob path before existence checking.
This solve the issue where Get-GhildItem does not behave correctly
when -Path contains special characters. For example,

Get-ChildItem -Path './`[dir`]'

will complain with error "Cannot find path ..." while

Get-ChildItem -Path './`[dir`]' -Depth 0

will work fine.

PR Checklist

[Feature] Fix Get-ChildItem -Path with wildcard char
ba213c1 
Unescape non-literal, non-glob path before existence checking.
This solve the issue where Get-GhildItem does not behave correctly
when -Path contains special characters. For example,
> Get-ChildItem -Path './`[dir`]'
will complain with error "Cannot find path ..." while
> Get-ChildItem -Path './`[dir`]' -Depth 0
will work fine.
kwkam mentioned this pull request Jul 30, 2018
Closed
11 tasks
kwkam changed the title [Feature] Fix Get-ChildItem -Path with wildcard char Fix Get-ChildItem -Path with wildcard char Jul 31, 2018

stale Bot commented Aug 30, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

stale Bot added the Stale label Aug 30, 2018
stale Bot removed the Stale label Sep 9, 2018

stale Bot commented Oct 9, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

stale Bot added the Stale label Oct 9, 2018

stale Bot commented Oct 19, 2018

Copy link
Copy Markdown

This PR has be automatically close because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it.
Thanks again for your contribution.
Community members are welcome to grab these works.

stale Bot closed this Oct 19, 2018

kwkam commented Nov 10, 2018

Copy link
Copy Markdown
Contributor Author

It seems that I cannot reopen this. Do I have to create a new PR?

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator

kwkam I believe if you submit a new commit to this branch it should allow you to reopen it / reopen automatically.

kwkam commented Jan 11, 2019

Copy link
Copy Markdown
Contributor Author

Rain Sallow (/u/ta11ow) (@vexx32) I have merged the latest master into this branch, but still there is no option for re-opening the PR. Maybe I do not have the permission to reopen my PR?

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 11, 2019

Copy link
Copy Markdown
Collaborator

That's very strange... I guess you can just open a new PR from the same branch?

kwkam mentioned this pull request Mar 31, 2019
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Bruce Payette (BrucePay) Awaiting requested review from BrucePay
Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL