FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Unit Tests for GetDateTest.cs and StartSleepTest.cs by TingLiu6 · Pull Request #775 · PowerShell/PowerShell · GitHub

/ PowerShell Public

Add Unit Tests for GetDateTest.cs and StartSleepTest.cs - #775

Merged
Andy Jordan (andyleejordan) merged 5 commits into
masterfrom
UnitTest_Temp
Apr 8, 2016
ConversationCommits (5)ChecksFiles changed
Merged

Add Unit Tests for GetDateTest.cs and StartSleepTest.cs#775
Andy Jordan (andyleejordan) merged 5 commits into
masterfrom
UnitTest_Temp

Conversation

Ting Liu [Wicresoft] (TingLiu6) commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

Please help to review, thanks!

This change is

Ting Liu [Wicresoft] (TingLiu6) commented Apr 7, 2016

Copy link
Copy Markdown
Contributor Author

Andy Jordan (@andschwa) , could you please help to merge this to master, thanks.

Andy Jordan (andyleejordan) commented Apr 7, 2016

Copy link
Copy Markdown
Member

James Truher (@JamesWTruher) Please review and merge.

JamesWTruher reviewed Apr 7, 2016
View reviewed changes
Comment thread test/powershell/Get-Date.Tests.ps1 Outdated

It "using -displayhint produces the correct output" {
$newLine = [Environment]::NewLine
Get-date -Date:"Jan 1, 2020" -DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date) | Out-String | Should be $newLine"Wednesday, January 1, 2020$newLine$newLine$newLine"

James Truher (JamesWTruher) Apr 7, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

-DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date)
should just be:
-DisplayHint Date
Also, I'd be happier if this was
$d = get-date -date "Jan 1, 2020" -DisplayHint Date | out-string
$d.Trim() | should be "Wednesday, January 1, 2020"

Ting Liu [Wicresoft] (TingLiu6) Apr 8, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed.

Andy Jordan (andyleejordan) commented Apr 8, 2016

Copy link
Copy Markdown
Member

LGTM.

Andy Jordan (andyleejordan) merged commit a5966a8 into master Apr 8, 2016
Andy Jordan (andyleejordan) deleted the UnitTest_Temp branch April 8, 2016 04:03

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10017, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9954, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9885, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9875, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9862, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9854, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9843, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Jul 17, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #9805, which has now been successfully released as v7.0.0-preview.2.:tada:

Handy links:

Deleted user (ghost) commented Aug 20, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10364, which has now been successfully released as v7.0.0-preview.3.:tada:

Handy links:

Deleted user (ghost) commented Sep 19, 2019

Copy link
Copy Markdown

🎉This issue was addressed in #10421, which has now been successfully released as v7.0.0-preview.4.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Merge pull request PowerShell#775 from PowerShell/UnitTest_Temp
0572b68 
Add Unit Tests for GetDateTest.cs and StartSleepTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

James Truher (JamesWTruher)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL